- Notifications
You must be signed in to change notification settings - Fork1.9k
inlineStr cell type support #1575#1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Could you please add a new test with that test file to make sure we don't lose this functionality over time? |
@alubbe, added integration test with the sample file. |
@Siemienik, could you please review and merge this PR? |
Yes, I will if only I found free time. |
sveisvei commentedJan 5, 2022
When will this be released? |
gaurav-cointab commentedMar 7, 2022
when will this be release, because right now in "4.3.0" also this fix is not present. We are getting the inlineStr cell as "NULL", please make a small release for this issue, if possible... Currently we are using the npm release version. Do we have to pull from github directly and then use the fix, or will you be making a release in npm also ? |
adrian-morariu-modus-create commentedSep 6, 2022
@Siemienik please release a new version with this fix |
Summary
Implementing inlineStr cell type fixing issue#1575
Test plan
Tested stream reading of the xlsx file that has cells defined as
<c ... t="inlineStr"><is><t>value here</t></is></c>- values gets populated, instead of null values before the fix.