- Notifications
You must be signed in to change notification settings - Fork1.9k
Add a test for CSV writeFile encoding#1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pputnam-NAVEX commentedNov 24, 2021
Was the new Excel document opened and checked after it was written to? I can successfully encode the file as UTF-8, check in console fine, but when Excel opens the document characters including the Hebrew text used in the test are gibberish. Notepad++ correctly displays it and if I use Notepad++ to encode it to UTF-8-BOM I can re-open the spreadsheet and it will display correctly. |
pputnam-NAVEX commentedNov 24, 2021
Adding: Right before the writeFile works, also if this same file is then read using readFile \ufeff is undetectable - unsure if this is something worth adding as BOM isn't recommended but limitations in viewability of UTF-8 characters when opening actual Excel files for non-technical or data visualization may be helpful. |
Summary
I saw a few issues (#995,#1473) regarding CSV output encoding, and I wondered if it was working.
Test plan
So I wrote a test... Turns out it is working.