- Notifications
You must be signed in to change notification settings - Fork1.9k
Refine typing for Column#1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+18 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_header, _key and width are dependent on defn and therefore maybe undefined.Add comment for properties that are dependent on style. Since style willbe set to an empty object when defn is not provided, these propertiesmay be undefined as well.Change references of Partial<Column> to Column since the undefinedproperties are directly handled inside the Column type definition.
Siemienik approved these changesOct 5, 2020
Member
Siemienik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
paliwalgaurav commentedFeb 1, 2021
Partial column thing should be there because now it's giving error. I don't want to define |
Author
nywleswoey commentedFeb 2, 2021
Fixed by Hesamp in4e38ad8 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to refine the type definition for
Column. This shouldresolve#1120Test plan
I derived this by looking at
column.js. Then I replacedindex.d.tsinnode_modules/exceljswith my changes and the typescript issue from#1120 went away.