Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Run linter with prettier 2#1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alubbe merged 4 commits intoexceljs:masterfromalubbe:linter
Sep 29, 2020
Merged

Run linter with prettier 2#1477

alubbe merged 4 commits intoexceljs:masterfromalubbe:linter
Sep 29, 2020

Conversation

@alubbe
Copy link
Member

Summary

Some files haven't had the linter applied to, so let's fix that :)

Test plan

No new tests are needed

@alubbealubbe requested review fromAlanscut,Siemienik andguyonroche and removed request forguyonrocheSeptember 28, 2020 10:37
Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This pr again introduce lots of changes, which has no sense. Lets we keep current style rules

@alubbe
Copy link
MemberAuthor

Agreed - I've reset the arrow-parens behaviour back to prettier v1 ('as-needed'). The other changes were always 'wrong', I think and they looks safe enough to merge

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've added more comments, If is it fine to you I'm going to propose some rules changes according to my comments 😉

Copy link
Member

@SiemienikSiemienik left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After some investigation, I changed max-len option to 100. Before was 160 - that value is too much for properly priettier 2 working.

As effect some improvements was introduced like:

https://github.com/exceljs/exceljs/pull/1477/files#diff-a083b92106d7d843e5f325cb350dbf25L102-R109

image

@alubbe
Copy link
MemberAuthor

alubbe commentedSep 29, 2020•
edited
Loading

Looks good, I also found another typo - fixed, will merge

Siemienik reacted with thumbs up emoji

@alubbealubbe merged commitd0e57f0 intoexceljs:masterSep 29, 2020
@alubbealubbe deleted the linter branchSeptember 29, 2020 07:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SiemienikSiemienikSiemienik approved these changes

@AlanscutAlanscutAwaiting requested review from Alanscut

@guyonrocheguyonrocheAwaiting requested review from guyonroche

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alubbe@Siemienik
[8]ページ先頭
©2009-2025 Movatter.jp