- Notifications
You must be signed in to change notification settings - Fork1.9k
grunt: skip babel transpile for core-js#1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously grunt build would transpile the output of browserify to transpile all dependencies, but this would make some dependencies, such as core-js, unexpectedly transpiled. Also, this way of transpiling would create source maps only targeting the browserify output instead of original source, and makes the final `dist/exceljs.js` larger than expected.* Fix Symbol.toString() related errors on IE11 caused by transpiling core-js* Reduce size for compiled dist* Keep original source maps before browserify
regexp not included
alubbe approved these changesSep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is great, thanks!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously grunt build would transpile the output of browserify to transpile all dependencies, but this would make some dependencies, such as core-js, unexpectedly transpiled. Also, this way of transpiling would create source maps only targeting the browserify output instead of original source, and makes the final
dist/exceljs.jslarger than expected.Test plan
Existing ci builds and manually tested in browser.
screenshot of source map