- Notifications
You must be signed in to change notification settings - Fork1.9k
Conversation
Merge pull requestexceljs#1327 from Subhajitdas298/master
Merge latest
ContributorAuthor
Subhajitdas298 commentedJul 1, 2020
@alubbe Please review this, and comment, if needs to be changed. Restructuring was needed, as rows currently have a lot of functionality now. And added api spec table for separated methods. |
Member
alubbe commentedJul 2, 2020
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified documentation. Separated add rows and splice functions. Added api specs for them.
Test plan
No additional testing needed.