NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.8k

Fix the error that comment does not delete at spliceColumn#1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Siemienik merged 2 commits intoexceljs:masterfromsdg9670:splice-comment-issue

Jun 20, 2020

Merged

Fix the error that comment does not delete at spliceColumn#1334

Siemienik merged 2 commits intoexceljs:masterfromsdg9670:splice-comment-issue

Jun 20, 2020

Conversation

Copy link

Contributor

sdg9670 commentedJun 17, 2020•
edited
Loading

Summary

Fix the error that comment does not delete at spliceColumn

Test plan

Test Source Code

constExcel=require('./lib/exceljs.nodejs');(async()=>{constwb=newExcel.Workbook();constws=wb.addWorksheet('testSheet');ws.addRow(['test1','test2','test3','test4','test5','test6','test7','test8']);constrow=ws.getRow(1);row.getCell(1).note='test1';row.getCell(2).note='test2';row.getCell(3).note='test3';row.getCell(4).note='test4';ws.spliceColumns(2,1);awaitwb.xlsx.writeFile('data.xlsx');})();

Existing Results

Result

Correct errors that SpliceColumn does not delete comment

6e6c130

sdg9670 changed the title~~Corrected the error that comment does not delete during spliceColumn operation.~~Fix the error that comment does not delete during spliceColumn operation.

Jun 17, 2020

sdg9670 changed the title~~Fix the error that comment does not delete during spliceColumn operation.~~Fix the error that comment does not delete at spliceColumn

Jun 17, 2020