Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bug fix can not read property date1904 of undefined#1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 2 commits intoexceljs:masterfrommouse9:bug/date-parsing-issue
Jun 28, 2020

Conversation

mouse9
Copy link

@mouse9mouse9 commentedJun 15, 2020
edited
Loading

Summary

Issue:
ExcelJs.stream.xlsx.WorkbookReader reading with styles: cache option was giving
Cannot read property 'date1904' of undefined

Reproduce with this code

const workbookReader = new excel.stream.xlsx.WorkbookReader(fileReadStream, { worksheets: 'emit', styles: 'cache', sharedStrings: 'cache', hyperlinks: 'ignore', entries: 'ignore' });    workbookReader.read();    workbookReader.on('worksheet', worksheet => {          worksheet.on('row', (row) => {...}     }

Above code will throw an error whenDD/MM/YYYY format date is given in the excel
e.g: 20/06/2020

I found that inlib/stream/xlsx/worksheet-reader.js we are using it but not checking for the undefined model case.

StarkDevelopers reacted with thumbs up emojiStarkDevelopers reacted with heart emoji
Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good for me, thanks

I have only one request - it's required to cover each detected (and fixed) bug by a test. Could I ask you to write at least one?

mouse9 reacted with thumbs up emoji
@mouse9
Copy link
Author

mouse9 commentedJun 18, 2020
edited
Loading

Yeah sure.
I understand, I was just waiting for your reply first.

I will add test cases now

Siemienik reacted with thumbs up emoji

@mouse9mouse9 mentioned this pull requestJun 23, 2020
@mouse9
Copy link
Author

@Siemienik I have added the integration test case for the same :)

@SiemienikSiemienik merged commitb7df1c5 intoexceljs:masterJun 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

@AlanscutAlanscutAlanscut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mouse9@Siemienik@Alanscut@yganatra

[8]ページ先頭

©2009-2025 Movatter.jp