- Notifications
You must be signed in to change notification settings - Fork1.9k
bug fix can not read property date1904 of undefined#1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good for me, thanks
I have only one request - it's required to cover each detected (and fixed) bug by a test. Could I ask you to write at least one?
mouse9 commentedJun 18, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah sure. I will add test cases now |
@Siemienik I have added the integration test case for the same :) |
Uh oh!
There was an error while loading.Please reload this page.
Summary
Issue:
ExcelJs.stream.xlsx.WorkbookReader reading with styles: cache option was giving
Cannot read property 'date1904' of undefined
Reproduce with this code
Above code will throw an error when
DD/MM/YYYY
format date is given in the excele.g: 20/06/2020
I found that in
lib/stream/xlsx/worksheet-reader.js
we are using it but not checking for the undefined model case.