- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix issue #1261 WorkbookWriter sheet.protect() function doesn't exist#1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| protect(password,options){ | ||
| // TODO: make this function truly async | ||
| // perhaps marshal to worker thread or something | ||
| returnnewPromise(resolve=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Whether this attribute should be declared inconstructor ().
// worksheet protectionthis.sheetProtection=null;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This has been added to the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this really work ? I set sheet protection to true it doesn't lock a particular cell
alubbe commentedMay 20, 2020
Please merge the current master into your branch |
alubbe commentedJun 2, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The implementation looks good, but I think we need a better test here. Ideally, write a file with a protection and then show that when reading the file again, the flag is set |
alubbe left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👆
Siemienik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@rheidari, have you possibility to made requested changes?
rheidari commentedAug 19, 2020
Apologies for the delay, I've updated the test! |
Changes
protectmethod toworksheet-writer.js(copied fromworksheet.js)