- Notifications
You must be signed in to change notification settings - Fork1.9k
fix issue #204 sets default column width#1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| constEnums=require('./enums'); | ||
| constcolCache=require('../utils/col-cache'); | ||
| constDEFAULT_COLUMN_WIDTH=9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm really happy to read your pull requests, good job. I had some issues with width before, so I feel twice satisfaction with your changes 👍
but I'm not sure, that it's the correct way to set a const value,
I think that should be property for worksheet and/or workbook, with a possibility to change it by a user.
May I'm wrong, so please clear me this and tell what are you thinking? 😄
SiemienikMar 22, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Even if I wrote a comment, I think these PR fix some issues anyway, so I approve it to merge 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Siemienik First of all, thank you very much for your approval, this will become my motivation. I really like exceljs, it is very helpful for my work, so I am happy to contribute a little bit of my own power to this software.
- When the user does not set the column width, I will set a default value for the column.
// single column settingsheet.getColumn(3).width=10;
- Users can globally set the column width of the entire worksheet
worksheet.properties.defaultColWidth=47;
@Siemienik should we merge this? |
I confirm that it works ok with |
Changes
When user-defined column properties, but the column width is not set, we should set a default value for the column box.
Fix for issueColumnwidth of 0 zero when setting numFmt #204 .