- Notifications
You must be signed in to change notification settings - Fork1.9k
[MAJOR VERSION] Move node v8 support to ES5 imports#1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Siemienik commentedMar 22, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
hmm, that true but, a lot of our users still uses node v8 - we should think about how to care about them :) |
alubbe commentedMar 25, 2020
Okay let's try a totally different approach then :) This is strictly speaking a semver-incompatible change, but I think the upgrade path is simple enough - what do you think? |
alubbe commentedMar 25, 2020
@guyonroche what's your take on supporting outdated versions of node? How often would you like to release a new major version of exceljs? |
alubbe commentedMar 27, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've also restored testing v8 on travis, so now that node v8 is a first class citizen as it is right now and the only breaking change is that users of node v8 will get a message to change their |
Siemienik commentedMar 27, 2020
Siemienik commentedMar 30, 2020
WIP because, 3.8.2 doesn't work now, we have to publish 3.8.3 version before v4. |
# Conflicts:#.travis.yml#package.json
alubbe commentedApr 27, 2020
I've resolved all merge conflicts and have added testing for node 14 |
This PR drops support for nodejs v8 and bumps the version to 4.0.0
v8 has been unsupported for almost 2 months now and we can use the major version change to start using node v10+ features like async iteration - what do you think?