Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[MAJOR VERSION] Move node v8 support to ES5 imports#1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alubbe merged 5 commits intoexceljs:masterfromalubbe:drop-v8
Jun 2, 2020

Conversation

@alubbe
Copy link
Member

This PR drops support for nodejs v8 and bumps the version to 4.0.0
v8 has been unsupported for almost 2 months now and we can use the major version change to start using node v10+ features like async iteration - what do you think?

@Siemienik
Copy link
Member

Siemienik commentedMar 22, 2020
edited
Loading

hmm, that true

but, a lot of our users still uses node v8 - we should think about how to care about them :)
or give some months to adapting their environments

@alubbealubbe changed the titleDrop support for nodejs v8Move node v8 support to ES5 importsMar 25, 2020
@alubbe
Copy link
MemberAuthor

Okay let's try a totally different approach then :)
I propose to move node v8 support to ES5 imports - users of the old version will get a clear message of what they need to change and everyone on node v10 and newer will get the full power and speed of newer features such as async iteration.

This is strictly speaking a semver-incompatible change, but I think the upgrade path is simple enough - what do you think?

Siemienik reacted with thumbs up emoji

@alubbe
Copy link
MemberAuthor

@guyonroche what's your take on supporting outdated versions of node? How often would you like to release a new major version of exceljs?

@alubbe
Copy link
MemberAuthor

alubbe commentedMar 27, 2020
edited
Loading

I've also restored testing v8 on travis, so now that node v8 is a first class citizen as it is right now and the only breaking change is that users of node v8 will get a message to change theirrequire statement. Can we merge that and publish it as 4.0.0@guyonroche ? Then I can finish my work on async iteration and stream cancellation

@Siemienik
Copy link
Member

We have to publish v3.8.3 from current master first - 3.8.2 has bug inside -#1179#1180#1178

@SiemienikSiemienik changed the titleMove node v8 support to ES5 importsWIP: Move node v8 support to ES5 importsMar 30, 2020
@Siemienik
Copy link
Member

WIP because, 3.8.2 doesn't work now, we have to publish 3.8.3 version before v4.

@alubbealubbe changed the titleWIP: Move node v8 support to ES5 imports[MAJOR VERSION] Move node v8 support to ES5 importsApr 2, 2020
@alubbealubbe mentioned this pull requestApr 16, 2020
@alubbe
Copy link
MemberAuthor

I've resolved all merge conflicts and have added testing for node 14

@alubbealubbe merged commita81830b intoexceljs:masterJun 2, 2020
@alubbealubbe deleted the drop-v8 branchJune 2, 2020 18:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@guyonrocheguyonrocheguyonroche approved these changes

@SiemienikSiemienikAwaiting requested review from Siemienik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alubbe@Siemienik@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp