NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.8k

Add benchmarking#1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alubbe merged 1 commit intoexceljs:masterfromalubbe:benchmarking

Mar 5, 2020

Merged

Add benchmarking#1139

alubbe merged 1 commit intoexceljs:masterfromalubbe:benchmarking

Mar 5, 2020

Conversation

Copy link

Member

alubbe commentedFeb 21, 2020

Summary

I believe it would be highly useful to have a way of running benchmarks, to understand how certain PRs impact performance. This PR adds an xlsx with 150k rows spread of 2 worksheets (data taken fromhttp://eforexcel.com/wp/downloads-18-sample-csv-files-data-sets-for-testing-sales/) as well as a newbenchmark task to our package.json.

Here are the numbers of the currentmaster on node v13:

####################################################WARMUP: Current memory usage: 8.6 MBWARMUP: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsWARMUP: huge xlsx file profiling finished in 6830msWARMUP: Current memory usage (before GC): 63.35 MBWARMUP: Current memory usage (after GC): 27.55 MB####################################################RUN 1: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 1: huge xlsx file profiling finished in 6681msRUN 1: Current memory usage (before GC): 47.6 MBRUN 1: Current memory usage (after GC): 23.56 MB####################################################RUN 2: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 2: huge xlsx file profiling finished in 6781msRUN 2: Current memory usage (before GC): 146.72 MBRUN 2: Current memory usage (after GC): 51.67 MB####################################################RUN 3: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 3: huge xlsx file profiling finished in 6320msRUN 3: Current memory usage (before GC): 174.9 MBRUN 3: Current memory usage (after GC): 51.65 MB

vs master before the saxes PR was merged:

####################################################WARMUP: Current memory usage: 8.55 MBWARMUP: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsWARMUP: huge xlsx file profiling finished in 25585msWARMUP: Current memory usage (before GC): 73.81 MBWARMUP: Current memory usage (after GC): 23.33 MB####################################################RUN 1: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 1: huge xlsx file profiling finished in 25488msRUN 1: Current memory usage (before GC): 36.12 MBRUN 1: Current memory usage (after GC): 20.33 MB####################################################RUN 2: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 2: huge xlsx file profiling finished in 24808msRUN 2: Current memory usage (before GC): 43.84 MBRUN 2: Current memory usage (after GC): 21.4 MB####################################################RUN 3: huge xlsx file profiling startedReading worksheet 1Reading row 50000Reading row 100000Reading worksheet 2Reading row 150000Processed 2 worksheets and 150002 rowsRUN 3: huge xlsx file profiling finished in 25397msRUN 3: Current memory usage (before GC): 32.42 MBRUN 3: Current memory usage (after GC): 19.63 MB

In short, we've gotten almost 4 times faster 🎉