- Notifications
You must be signed in to change notification settings - Fork1.9k
[WIP] Replace sax with saxes#1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
alubbe commentedFeb 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedFeb 14, 2020
This was referencedJan 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
THIS PR IS NOT READY TO BE MERGED - IT IS A PoC
As mentioned last year (#748 (comment)), I believe we should consider replacing
saxwithsaxes. Here are my main motivating reasons:saxhas not been maitained in close to 3 yearssaxesuses ES6 and modern streams, which should enable us to use async iterators, which a) massively simplifies the code responsible for the stream control logic and b) handles backpressure for us, which could mean we might be able to drop our custom flow control implementationsaxesis faster thansaxThis PR is a work in progress right now and cannot be merged until
saxesv5 is officially released. It also requires that we replace uglify with terser to handle the ES6 code thatsaxespublishes.Looking forward to your feedback!