NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.8k

Replace uglify with terser#1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Siemienik merged 1 commit intoexceljs:masterfromalubbe:terser

Feb 18, 2020

Merged

Replace uglify with terser#1125

Siemienik merged 1 commit intoexceljs:masterfromalubbe:terser

Feb 18, 2020

Conversation

Copy link

Member

alubbe commentedFeb 13, 2020

Uglify can not handle ES6+, such asconst andlet. Some npm dependencies, likesaxes, can not be used without replacing uglify with the more modern terser because they publish modern JS.

alubbe requested review fromguyonroche andSiemienik

February 13, 2020 05:37

alubbe mentioned this pull request

Feb 13, 2020

[WIP] Replace sax with saxes#1127

Merged

Copy link

Member

Siemienik commentedFeb 13, 2020

@alubbe

something went wrong while testing onnode:8, could you check what's going on?
hmm.. currently I haven't a possibility to check these changes but for me, that's really ok 😄

Replace uglify with terser

1c404a2

alubbe force-pushed theterser branch from11a3937 to1c404a2Compare

February 14, 2020 08:53

Copy link

MemberAuthor

alubbe commentedFeb 14, 2020

I don't understand the failure here - because it looks like mocha crashes, for no clear reason, but this PR#1127 which has the same change, is somehow green. Is it flaky? Am I missing something?