Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update issue templates#1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 3 commits intomasterfromf/bug-template
Feb 8, 2020
Merged

Update issue templates#1112

Siemienik merged 3 commits intomasterfromf/bug-template
Feb 8, 2020

Conversation

@Siemienik
Copy link
Member

@SiemienikSiemienik commentedFeb 4, 2020
edited
Loading

We have a lot of bugs reported which has a poor description, it does not help us to reproduce and fix it quickly.
So I think the issue template should improve the situation :)

Alanscut and kigh-ota reacted with thumbs up emoji
@alubbe
Copy link
Member

I think that's a great idea, but I believe it needs to be short - otherwise users might end up ignoring it. Personally, I likehttps://raw.githubusercontent.com/facebook/jest/master/.github/ISSUE_TEMPLATE/bug.md so I've shortened our template to be similar to that. What do you think?

Also pinging@guyonroche

@Alanscut
Copy link
Member

why not also add a PR template ?😃

Siemienik reacted with heart emoji

@Siemienik
Copy link
MemberAuthor

Siemienik commentedFeb 6, 2020
edited
Loading

@Alanscut yeah it's great idea:)

@Siemienik
Copy link
MemberAuthor

Siemienik commentedFeb 6, 2020
edited
Loading

@alubbe for me the important thing is to give me a test which will fail before fixation. We have a lot of bugs reported, that we need a lot of time to inspect and analyze them.

Test code for an issue will give us:

  1. set the quality of issues to the highest level
  2. reduce the fixation time cost
  3. encourage to creating new PRs (if someone makes a test it will probably make a fixation :) )

In the other side, You have right, the short template should increase bug reports amount.
So I have shared my thoughts with you, and I'm really open to change my vision to something else 😄

@alubbe@Alanscut what do you think?

@alubbe
Copy link
Member

I completely agree, that's why I tried to find a 'middle-ground' approach, that both looks short, so that it actually gets read instead of deleted, but still wants a code example. That's not as much as a fully blown test case, but it's close enough. Here's my suggestion:

## Steps To Reproduce<!-- The exact steps required to reproduce the issue, ideally with a code example and an expectation (like in a unit test) -->```javascriptconst wb = new ExcelJS.Workbook();const ws = wb.addWorksheet('XYZ');ws.getCell('A1').value = 7;expect(ws.getCell('A1').value).to.equal(7);

@SiemienikSiemienik merged commitb5fe6a1 intomasterFeb 8, 2020
@alubbealubbe deleted the f/bug-template branchFebruary 12, 2020 07:21
@alubbe
Copy link
Member

@Alanscut this PR adds more templates:#1128

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Siemienik@alubbe@Alanscut

[8]ページ先頭

©2009-2025 Movatter.jp