Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #1103:editAs not working#1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 5 commits intoexceljs:masterfromAlanscut:fix_editAs
Feb 10, 2020
Merged

Conversation

@Alanscut
Copy link
Member

@alubbe
Copy link
Member

I'm not entirely sure what this PR is about -@Siemienik do you know?@Alanscut could you elaborate a little bit and maybe provide a test case?

@Alanscut
Copy link
MemberAuthor

ok, I will add some test for it later.
when you add an image to a worksheet, propertyeditAs will control how the image is anchored to the cell(s). it could be undefined,oneCell orabsolute. But when you set it toabsolute, the value ofeditAs in generated excel file will still beoneCell.
https://github.com/exceljs/exceljs/blob/master/README.md#add-image-over-a-range
pr-1104

@Alanscut
Copy link
MemberAuthor

there is another problem. The README saysundefined is the default value of propertyeditAs, however, the actual situation is thatoneCell is the default value. In fact, when creating a Excel file and inserting an image to it, the default property of editAs isoneCell too. So should I change the readme file?

@Siemienik
Copy link
Member

AD.undefined in documentation - I think, we should update readme, and all will be ok.

@alubbe
Copy link
Member

@Alanscut yeah let's update the README and then we're good to go

@SiemienikSiemienik merged commit9fa0c13 intoexceljs:masterFeb 10, 2020
@AlanscutAlanscut deleted the fix_editAs branchMarch 5, 2020 10:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alanscut@alubbe@Siemienik

[8]ページ先頭

©2009-2025 Movatter.jp