Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update TS definition to reference proper internal libraries#1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfromjakawell:ts-def-imports
Jan 27, 2020

Conversation

@jakawell
Copy link
Contributor

Summary

  • Replace empty "Stream" interface with the Node internal "stream.Stream" interface
  • Replace empty "Writable" interface with the Node internal "events.EventEmitter" interface

Notes

When using the library with TypeScript, I noticed that a couple of empty interfaces were causing errors in the TS parsing. I checked the source code and verified the correct internal interfaces so that the typings are accurate.

I know unit tests are required for PRs, but I don't see anywhere in this project that it has unit tests for the TypeScript definition, and I'm not really sure how to do that (or if it would even be useful). Let me know if I'm wrong!

* Replace empty "Stream" interface with the Node internal "stream.Stream" interface* Replace empty "Writable" interface with the Node internal "events.EventEmitter" interface
@guyonroche
Copy link
Collaborator

@jakawell thanks for the fix.
Regarding tests - I agree it would be useful to have a test that validates the type files. I think it could work by adding typescript, et al, as dev dependencies and having a new flavour "test:typescript" that would only work if the types parsed correctly. I'll see if I can make some that fail before merging this PR

jakawell reacted with thumbs up emoji

@guyonrocheguyonroche merged commite8a0d2b intoexceljs:masterJan 27, 2020
@guyonroche
Copy link
Collaborator

@jakawell - I've made a little progress. I've added a new test folder: spec/typescript with a couple of tests that execute ok but now they fail due to typescript compiler errors.
See: spec/typescript/exceljs.spec.ts - If I change the code to use:
const stream = wb2.xlsx.createInputStream() as any;
the test runs ok, but take away the "as any" and it fails. Do you know what is wrong?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakawell@guyonroche
[8]ページ先頭
©2009-2025 Movatter.jp