Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Duplicate rows#1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 6 commits intoexceljs:masterfromcbeltrangomez84:duplicate-rows
Jan 23, 2020
Merged

Conversation

cbeltrangomez84
Copy link
Contributor

Thanks@Siemienik and@guyonroche for the suggestions.

I added the explanation in README as asked.

Regards

@guyonroche
Copy link
Collaborator

@cbeltrangomez84 oops - my apologies, after I saw the original PR was merged, I went ahead and refactored it. I'll resolve the collisions so we can include your README changes. Thanks

cbeltrangomez84 reacted with thumbs up emoji

@guyonrocheguyonroche merged commit2551167 intoexceljs:masterJan 23, 2020
@cbeltrangomez84
Copy link
ContributorAuthor

Hi@guyonroche thanks for refactoring the code, one test is failing because the default value for the 'insert' argument in my code was false. Since the refactor is true it doesn`t match the test.

Could you change the argument? or if you prefer I'd change the test.

Thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cbeltrangomez84@guyonroche
[8]ページ先頭
©2009-2025 Movatter.jp