NotificationsYou must be signed in to change notification settings
Fork1.9k
Star15k

Fix problems caused by case of worksheet names#1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

guyonroche merged 2 commits intoexceljs:masterfromAlanscut:master

Jan 17, 2020

Merged

Fix problems caused by case of worksheet names#1065

guyonroche merged 2 commits intoexceljs:masterfromAlanscut:master

Jan 17, 2020

Conversation

Copy link

Member

Alanscut commentedJan 2, 2020

Changes

1.The sheet name of the excel file created in the windows system is not case sensitive. But theworkbook.addWorksheet () method does not do the corresponding processing, This PR fixes issues caused by case of sheet names.

2.fix for#1064

Fix problems caused by case of worksheet names

3c13455

Alanscut closed this

Jan 2, 2020

Alanscut reopened this

Jan 2, 2020

Fix errors

6d0d06a

Copy link

Member

Siemienik commentedJan 11, 2020

@Alanscut Is will still working when it will attempt to read file with two worksheets named: "name", "NAME" ?

Copy link

MemberAuthor

Alanscut commentedJan 13, 2020

@Siemienik yes, it could. But when we create a file with two worksheets with the same names regardless of case, the file will report an error when opening it. So when we prevent creating such file, the case you mentioned will not exist.