- Notifications
You must be signed in to change notification settings - Fork1.9k
Update eslint plugins and configs#1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The eslint-config-airbnb targets React projects and Excel.Js doesn't use React.The package suggests eslint-config-airbnb-base for non-React projects so that we should use it.https://www.npmjs.com/package/eslint-config-airbnb> If you don't need React, see eslint-config-airbnb-base.
Excel.JS has exported original source code since v3.0.0. This means new ECMAScript features which aren't supported by Node.JS causes errors.The esling-plugin-node warns such features so that we can catch mistakes before CI fails.https://www.npmjs.com/package/eslint-plugin-node
There are no reason to use Babel for eslint because Excel.JS has dropped Babel other than transpiling code.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes following eslint plugins and configs changes:
Use eslint-config-airbnb-base
The eslint-config-airbnb targets React projects and Excel.JS doesn't use React.
The package suggests eslint-config-airbnb-base for non-React projects so that we should use it.
https://www.npmjs.com/package/eslint-config-airbnb
Add and enable eslint-plugin-node
Excel.JS has exported original source code since v3.0.0. This means new ECMAScript features which aren't supported by Node.JS cause errors.
The esling-plugin-node warns such features so that we can catch mistakes before CI fails.
https://www.npmjs.com/package/eslint-plugin-node
Use default parser (Espree) for ESLint
There are no reason to use Babel for ESLlint because Excel.JS has dropped Babel other than transpiling code.