- Notifications
You must be signed in to change notification settings - Fork1.9k
Description
I'm creating a TypeScript definition file (will push back into the project when done), and noticed that every setter is also returning the value set - this does nothing and is unused, so thereturn
itself can be removed (it's just wasting space and potentially creating confusion):
IE.https://github.com/guyonroche/exceljs/blob/master/lib/doc/cell.js#L85
getnumFmt(){returnthis.style.numFmt;},setnumFmt(value){returnthis.style.numFmt=value;},
...should be...
getnumFmt(){returnthis.style.numFmt;},setnumFmt(value){this.style.numFmt=value;},
A cascading sum likea = b = c
will call the getter onc
, then the setter onb
, then the getter onb
, and finally the setter ona
.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/set
(Although it's not directly clear from the docs, there is an explicitreturn
in the getter, and none in the setter, in addition to all the examples.)