Commitab776ef

authored

Merge pull request#1480 from Bene-Graham/fix-bug-1027

Fixed undefined ref error when setting a data validation that is a range of cells at the worksheet level

2 parentsebb31f2 +02c7dab commitab776efCopy full SHA for ab776ef

File tree

+31

-1

lines changed

+31

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,14 @@ function optimiseDataValidations(model) {`
`51`	`51`	`returndvList`
`52`	`52`	`.map(dv=>{`
`53`	`53`	`if(!dv.marked){`
`54`		`-constaddr=colCache.decodeAddress(dv.address);`
	`54`	`+constaddr=colCache.decodeEx(dv.address);`
	`55`	`+if(addr.dimensions){`
	`56`	`+dvMap[addr.dimensions].marked=true;`
	`57`	`+return{`
	`58`	`+ ...dv.dataValidation,`
	`59`	`+sqref:dv.address,`
	`60`	`+};`
	`61`	`+}`
`55`	`62`
`56`	`63`	`// iterate downwards - finding matching cells`
`57`	`64`	`letheight=1;`

Lines changed: 23 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,23 @@`
	`1`	`+constExcelJS=verquire('exceljs');`
	`2`	`+`
	`3`	`+constTEST_XLSX_FILE_NAME='./spec/out/wb.test.xlsx';`
	`4`	`+`
	`5`	`+describe('github issues',()=>{`
	`6`	`+it('issue 1027 - Broken due to Cannot set property \'marked\' of undefined error',()=>{`
	`7`	`+constwb=newExcelJS.Workbook();`
	`8`	`+constws=wb.addWorksheet('Sheet1');`
	`9`	`+`
	`10`	`+constrange='A2:A1048576';`
	`11`	`+`
	`12`	`+ws.dataValidations.model[range]={`
	`13`	`+allowBlank:true,`
	`14`	`+error:'Please use the drop down to select a valid value',`
	`15`	`+errorTitle:'Invalid Selection',`
	`16`	`+formulae:['"Apples,Bananas,Oranges"'],`
	`17`	`+showErrorMessage:true,`
	`18`	`+type:'list',`
	`19`	`+};`
	`20`	`+`
	`21`	`+returnwb.xlsx.writeFile(TEST_XLSX_FILE_NAME);`
	`22`	`+});`
	`23`	`+});`

Comments

(0)