Commit478e2a0

and

authored

Add characters cannot be used for worksheet name (#2126)

Co-authored-by: Siemienik Pawel <hi@siemienik.com>

1 parent202d2e4 commit478e2a0Copy full SHA for 478e2a0

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,9 +60,9 @@ class Workbook {`
`60`	`60`
`61`	`61`	`// Illegal character in worksheet name: asterisk (*), question mark (?),`
`62`	`62`	`// colon (:), forward slash (/ \), or bracket ([])`
`63`		`-if(/[*?:/\\[\]]/.test(name)){`
	`63`	`+if(/[*?:/\\[\]＊？：￥／＼［］]/.test(name)){`
`64`	`64`	`thrownewError(`
`65`		-`Worksheet name${name} cannot include any of the following characters: * ? : \\ / [ ]`
	`65`	+`Worksheet name${name} cannot include any of the following characters: * ? : \\ / [ ] ＊？：￥／＼［］`
`66`	`66`	`);`
`67`	`67`	`}`
`68`	`68`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -702,11 +702,11 @@ describe('Worksheet', () => {`
`702`	`702`	`it('throws an error',()=>{`
`703`	`703`	`constworkbook=newExcelJS.Workbook();`
`704`	`704`
`705`		`-constinvalidCharacters=['*','?',':','/','\\','[',']'];`
	`705`	`+constinvalidCharacters=['*','?',':','/','\\','[',']','＊','？','：','￥','／','＼','［','］'];`
`706`	`706`
`707`	`707`	`for(constinvalidCharacterofinvalidCharacters){`
`708`	`708`	`expect(()=>workbook.addWorksheet(invalidCharacter)).to.throw(`
`709`		-`Worksheet name${invalidCharacter} cannot include any of the following characters: * ? : \\ / [ ]`
	`709`	+`Worksheet name${invalidCharacter} cannot include any of the following characters: * ? : \\ / [ ] ＊？：￥／＼［］`
`710`	`710`	`);`
`711`	`711`	`}`
`712`	`712`	`});`

Comments

(0)