Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: upgrade go 1.25#22904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
chore: upgrade go 1.25#22904
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: Michael Geers <michael@geers.tv>
This reverts commit7a5474e.
Co-authored-by: interstart <toth.zoltan@hotmail.hu>Co-authored-by: Qian Qin <mail@qianqin.de>Co-authored-by: Ante Karamatic <ante@karamatic.hr>Co-authored-by: Žiga Deisinger <ziga@deisinger.si>Co-authored-by: Nick Galfas <nick@galfas.gr>Co-authored-by: 19atlas <o.ustuncelik@gmail.com>
This reverts commitebbcabb.
Co-authored-by: Michael Geers <michael@geers.tv>Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>Co-authored-by: Michael Geers <michael@geers.tv>
Co-authored-by: Michael Geers <michael@geers.tv>
Co-authored-by: Sam Debruyn <sam@debruyn.dev>Co-authored-by: Максим Горпиніч <gorpinicmaksim5@gmail.com>Co-authored-by: RTTTC <94727758+RTTTC@users.noreply.github.com>Co-authored-by: aerucu <abdulkadir@erucu.de>Co-authored-by: frankb-CZ <frantisek.budinsky@gmail.com>Co-authored-by: Максим Горпиніч <gorpinicmaksim0@gmail.com>Co-authored-by: Jonas Gate <tidy.koala8317@brot.se>Co-authored-by: Patrick Nærvig Wøhlk <patrick@webbanditten.dk>
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The
for range numloops (where num is an int) won’t compile—replace with a classicfor i := 0; i < num; i++or range over a slice. - When calling
wg.Goinside loops, make sure to capture loop variables (e.g.i,lp) in the closure or pass them as parameters so each goroutine sees the correct value.
Prompt for AI Agents
Please address the comments from this code review:##Overall Comments- The`for range num` loops (where num is an int) won’t compile—replace with a classic`for i := 0; i < num; i++` or range over a slice.- When calling`wg.Go` inside loops, make sure to capture loop variables (e.g.`i`,`lp`) in the closure or pass them as parameters so each goroutine sees the correct value.##Individual Comments###Comment 1<location>`cmd/detect/work.go:17` </location><code_context>+func workers(log*util.Logger, num int, ips <-chan string, hits chan<-[]tasks.Result)*sync.WaitGroup { var wg sync.WaitGroup+ for range num {-wg.Add(1)-go func() {</code_context><issue_to_address>Using 'for range num' is incorrect for iterating an integer count.Replace 'for range num' with 'for i := 0; i < num; i++ {' to ensure the loop runs 'num' times and spawns the intended number of workers.</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Uh oh!
There was an error while loading.Please reload this page.
6f03177 intomaster 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
thecem pushed a commit to thecem/evcc that referenced this pull requestSep 11, 2025
StarF666 pushed a commit to StarF666/evcc that referenced this pull requestOct 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Depends ongolangci/golangci-lint#5872