Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix empty attribute crash in DataChannelRereader2#775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletionssrc/main/java/ev3dev/utils/DataChannelRereader2.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,17 +90,18 @@ public String readString() {
// try to do the read
// only one try, as:
// - value >0 indicates success
// - value =0does not tell us much, as there's a possibility of reading anempty attribute
// - value <0 indicatesfailure
// - value =0indicatesempty attribute (???)
// - value <0 indicatesempty attribute
int n = channel.read(buffer, 0);
if (n == -1) {
throw new IOException("Premature end of file " + path);
// minus one reliably occurs on empty file, zero should be similar
if (n <= 0) {
return "";
}

// strip trailing newline & return data as a string
// rationale: ev3dev sysfs often appends \n, but this breaks parseFloat/parseInt/...
byte[] bytes = buffer.array();
if (n > 0 &&bytes[n - 1] == '\n') {
if (bytes[n - 1] == '\n') {
return new String(bytes, 0, n - 1, StandardCharsets.UTF_8);
} else {
return new String(bytes, 0, n, StandardCharsets.UTF_8);
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp