- Notifications
You must be signed in to change notification settings - Fork46
Fix empty attribute crash in DataChannelRereader2#775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix empty attribute crash in DataChannelRereader2#775
Conversation
3c3545f to1a18470CompareNACK to |
1a18470 to6ddcaf9Compare6ddcaf9 tof356d8bCompare| thrownewIOException("Premature end of file "); | ||
| } | ||
| }while (n <=0); | ||
| byteBuffer.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@JakubVanek, restore the original code. Allow people develop the ideas
JakubVanekJan 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this seems to be already fixed (i usually rewrite git history usinggit rebase -i to have clean commit sequences)
Uh oh!
There was an error while loading.Please reload this page.
This PR intends to fix the issue described in#765 (comment) for DCR2. DCR1 should already be fixed from#778.