Better error handling #509#528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

whysage wants to merge2 commits intoets-labs:develop

base:develop

Choose a base branch

fromwhysage:issue-509-better-error-handling

Open

Better error handling #509#528

whysage wants to merge2 commits intoets-labs:developfromwhysage:issue-509-better-error-handling

Conversation

Copy link

Contributor

whysage commentedNov 1, 2021

Add providers log on error.

ets-labs#509

4ecf6cd

Add providers log on error.

whysage changed the title~~#509~~Better error handling #509

Nov 1, 2021

Copy link

ContributorAuthor

whysage commentedNov 1, 2021•
edited
Loading

@rmk135
Please review PR.
I'll not sure about it.

Here -#510 - you write that after reraise exception all exceptions will be just general 'Exception'.
I test my code by adding addition try here
src/dependency_injector/providers.pxd
line 582
try: return call(*args, **kwargs) except Exception as exception: raise exception

and receive type of Exception was TypeError (I used this demo
https://github.com/ets-labs/python-dependency-injector/blob/master/examples/demo/with_di.py
without env var timeout - so error was - TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType')

Also, I'm not sure about printing providers, Maybe we can log them somewhere.
Please advise.

Addition idea about problem was to add ENV var like DEPENDENCY_INJECTION_DEBUG_MODE
and print called providers only it is enabled.

I think this issue is very important - for me, it is real hell to find error in dozens providers by unclear error message.
Please help :-)