- Notifications
You must be signed in to change notification settings - Fork335
ESM#450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
brettz9 wants to merge6 commits intoestools:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
ESM#450
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Update: Use new SourceMapConsumer API in test- Build: Provide browserified builds with npm package- Travis: Drop 4, 6, 8; Add 10, 12, 14; check build- Maintenance: Add `.editorconfig`- Docs: Use fenced code blocks in README (for syntax highlighting)- npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors`- npm: Restore `optionator` to a regular dep. (used in published binary file)- npm: Drop unused semver, minimist- npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps.- npm: Drop bluebird in favor of ES Promises- npm: Use more recently maintained browserify + uglifyify- npm: Replace linting and testing scripts in Gulpfile with npm scripts
- npm: Update package-lock version
- npm: update devDeps.- npm: Update package-lock version
BREAKING CHANGE:Adds `exports`Also:1. updates benchmark2. fixes escodegen with missing options3. Bumps travis versions4. bumps devDep.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on#410 in such a way as to use Rollup instead of browserify. I used browserify in that PR as it meant there were fewer changes necessary, but my intent was always to provide this here as ESM.
These are breaking changes as a result of
exports(and if you're ok with the different paths I set up).If the number of changes here are manageable, I can justclose#410 , and if not, I can rebase this on#410 if it may be acceptable.
A few items to mention...
browserexport, as I've switched to separate entry points for browser and Node. I also haven't included aversionexport. Let me know if you want to remove these or ensure they still exist.distif that is all right; haven't updated the README yet with the new paths, as I wasn't sure you would be ok with them.