- Notifications
You must be signed in to change notification settings - Fork335
Fix #365#437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
lucivpav wants to merge27 commits intoestools:masterChoose a base branch fromlucivpav:fix-365
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Fix #365#437
Changes from1 commit
Commits
Show all changes
27 commits Select commitHold shift + click to select a range
0d54237 add tests
lucivpavd5a507d improve the "throw" fix
lucivpav2cc7937 add failing arrow function test
lucivpav3394a26 replace the tests with a single thorough test
lucivpava80ae88 add another test - ()expression inside of a return expression
lucivpava5790be more thought out fix; WIP
lucivpav2a1ed4e proper fix
lucivpav4fa78f0 cleanup
lucivpav6bb44bb cleanup
lucivpavb44cff1 cleanup
lucivpav6e566cf prettify
lucivpav0ff6beb fix problem with with default function parameters
ce9e1ce fix problem with unwanted parentheses in imports
acc9cd0 revert no-op change
da7d71c dont parenthesize variable declaration expressions
873307f revert unwanted new files
bb30704 revert logic to simplify PR; only parenthesize at a level where it is…
3e73ef3 Merge branch 'master' into github/fix-365
34cd8c6 nits
fae4df2 nit
91c5ee0 improve performance
2cfc090 fix isParenthesized zero length input behavior
9bc0f12 use a single isParenthesized() fn instead of additional isParenthesiz…
ca68677 use constant for newline instead of a literal
d669661 handle edge case in addMultiLineIndent()
fb1ab86 add test, where parenthesis should not be added
3f8ae47 remove unused function parameter
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix isParenthesized zero length input behavior
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
3 changes: 3 additions & 0 deletionsescodegen.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.