- Notifications
You must be signed in to change notification settings - Fork335
feat: add jsx support#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
erquhart wants to merge2 commits intoestools:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
Changes from1 commit
Commits
Show all changes
2 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
feat: add jsx support
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit9a3f820e4db66e76a87e2dd2aeda43c09d56da4c
There are no files selected for viewing
84 changes: 83 additions & 1 deletionescodegen.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2434,8 +2434,90 @@ | ||
| ModuleSpecifier:function(expr,precedence,flags){ | ||
| returnthis.Literal(expr,precedence,flags); | ||
| }, | ||
| JSXIdentifier:function(expr,precedence,flags){ | ||
| returnexpr.name; | ||
| }, | ||
| JSXMemberExpression:function(expr,precedence,flags){ | ||
| varresult=[]; | ||
| result.push(this.generateExpression(expr.object,precedence,flags)); | ||
| result.push('.'); | ||
| result.push(this.generateExpression(expr.property,precedence,flags)); | ||
| returnresult; | ||
| }, | ||
| JSXNamespacedName:function(expr,precedence,flags){ | ||
| varresult=[]; | ||
| result.push(this.generateExpression(expr.namespace,precedence,flags)); | ||
| result.push(':'); | ||
| result.push(this.generateExpression(expr.name,precedence,flags)); | ||
| returnresult; | ||
| }, | ||
| JSXEmptyExpression:function(expr,precedence,flags){ | ||
| return''; | ||
| }, | ||
| JSXExpressionContainer:function(expr,precedence,flags){ | ||
| return['{',this.generateExpression(expr.expression,precedence,flags),'}']; | ||
| }, | ||
| JSXOpeningElement:function(expr,precedence,flags){ | ||
| varresult,i,iz; | ||
| result=['<']; | ||
| result.push(this.generateExpression(expr.name,precedence,flags)); | ||
| if(expr.attributes){ | ||
| for(i=0,iz=expr.attributes.length;i<iz;++i){ | ||
| result.push(' '); | ||
| result.push(this.generateExpression(expr.attributes[i],precedence,flags)); | ||
| } | ||
| } | ||
| result.push(expr.selfClosing ?[' />'] :'>'); | ||
erquhart marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| returnresult; | ||
| }, | ||
| JSXClosingElement:function(expr,precedence,flags){ | ||
| return['</',this.generateExpression(expr.name,precedence,flags),'>']; | ||
| }, | ||
| JSXAttribute:function(expr,precedence,flags){ | ||
| varresult=[]; | ||
| result.push(this.generateExpression(expr.name,precedence,flags)); | ||
| result.push('='); | ||
| if(expr.value.type==='Literal'){ | ||
| result.push(this.generateExpression(expr.value,precedence,flags)); | ||
| returnresult; | ||
| } | ||
| if(expr.value.type==='JSXExpressionContainer'){ | ||
| result.push(this.generateExpression(expr.value.expression,precedence,flags)); | ||
| returnresult; | ||
| } | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. You also need to handle >require('escodegen').generate(require('esprima').parse('(<Foo bar=<Quux/>/>)',{jsx:true}));'<Foo undefined />;' And Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Totally forgot about boolean attributes, good catch 👍 | ||
| }, | ||
| JSXSpreadAttribute:function(expr,precedence,flags){ | ||
| return['{...',this.generateExpression(expr.argument,precedence,flags),'}']; | ||
| }, | ||
| JSXText:function(expr,precedence,flags){ | ||
| returnexpr.value; | ||
| }, | ||
| JSXElement:function(expr,precedence,flags){ | ||
| varresult,i,iz; | ||
| result=[]; | ||
| result.push(this.generateExpression(expr.openingElement,precedence,flags)); | ||
| if(expr.children){ | ||
| for(i=0,iz=expr.children.length;i<iz;++i){ | ||
| result.push(this.generateExpression(expr.children[i],precedence,flags)); | ||
| } | ||
| } | ||
| if(expr.closingElement){ | ||
| result.push(this.generateExpression(expr.closingElement,precedence,flags)); | ||
| } | ||
| returnresult; | ||
| } | ||
| }; | ||
| merge(CodeGenerator.prototype,CodeGenerator.Expression); | ||
2 changes: 1 addition & 1 deletionpackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.