Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add overloads to support __FlashStringHelper like ESP8266 has them.#8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 3 commits intoespressif:masterfromdok-net:fix_8108
May 3, 2023

Conversation

@dok-net
Copy link
Contributor

Fixes#8108

pgrawehr reacted with thumbs up emoji
@CLAassistant
Copy link

CLAassistant commentedApr 23, 2023•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dok-netdok-net marked this pull request as draftApril 23, 2023 15:41
@github-actions
Copy link
Contributor

External libraries build test

LibraryESP32ESP32C3ESP32S2ESP32S3
Adafruit NeoPixel1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ArduinoBLE1 ✅ -> 1 ✅1 ✅ -> 1 ✅N/A1 ✅ -> 1 ✅
ESP32Servo4 ✅ -> 4 ✅4 ✅ -> 4 ✅4 ✅ -> 4 ✅4 ✅ -> 4 ✅
ESPAsyncWebServer3 ✅ 1⚠️ -> 3 ✅ 1⚠️4 ❌ -> 4 ❌3 ✅ 1⚠️ -> 3 ✅ 1⚠️3 ✅ 1⚠️ -> 3 ✅ 1⚠️
FastLED1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
IRremote1⚠️ -> 1⚠️1 ❌ -> 1 ❌1 ✅ -> 1 ✅1 ✅ -> 1 ✅

@VojtechBartoskaVojtechBartoska added the Priority: High 🗻Issues with high priority which needs to be solved first. labelApr 24, 2023
@github-actions
Copy link
Contributor

External libraries build test

LibraryESP32ESP32C3ESP32S2ESP32S3
Adafruit NeoPixel1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ArduinoBLE1 ✅ -> 1 ✅1 ✅ -> 1 ✅N/A1 ✅ -> 1 ✅
ESP32Servo4 ✅ -> 4 ✅4 ✅ -> 4 ✅4 ✅ -> 4 ✅4 ✅ -> 4 ✅
ESPAsyncWebServer3 ✅ 1⚠️ -> 3 ✅ 1⚠️4 ❌ -> 4 ❌3 ✅ 1⚠️ -> 3 ✅ 1⚠️3 ✅ 1⚠️ -> 3 ✅ 1⚠️
FastLED1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
IRremote1⚠️ -> 1⚠️1 ❌ -> 1 ❌1 ✅ -> 1 ✅1 ✅ -> 1 ✅

Copy link
Collaborator

@mrengineer7777mrengineer7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Restores previous definitions forF andFPSTR in Wstring.h. This should fix breaking changes in other libraries. I'm not sure about the other changes introduced by this PR.

@me-no-dev
Copy link
Member

Can you pease split the changes into separate PRs. There seem to be three unrelated changes.
F() used to be#define F(string_literal) (FPSTR(PSTR(string_literal)))

Safiqq reacted with thumbs down emoji

@dok-net
Copy link
ContributorAuthor

dok-net commentedApr 25, 2023•
edited
Loading

Can you pease split the changes into separate PRs.

Oh dear, I partly understand where this request is coming from, but honestly, I don't have time on my hands to do this RIGHT until 2 weekends away from now. And I don't know how much better it will be in two or three steps. Seeing the first attempt, just reverting the macros breaks something else. I honestly have to ask you to review this as is, because the dependencies are just there. Of course it could be attempted to find out which of the changes, macros, libs, could perhaps stand without the other, probably the libs because they ADD wrappers now, but for that exact same reason, why not review this PR as it stands, pleeeeze?

I'm sorry the first PR didn't work for some 3rd party libs.

@dok-net
Copy link
ContributorAuthor

dok-net commentedApr 25, 2023•
edited
Loading

F() used to be#define F(string_literal) (FPSTR(PSTR(string_literal)))

The reverted macros now just drop the PSTR, becauses it's a dummy on ESP32, and will always be (?):
cores/esp32/pgmspace.h:#define PSTR(s) (s)

@tueddy
Copy link
Contributor

Please add this to2.0.9, it's a high visible show stopper

mhaberler reacted with thumbs up emoji

@github-actions
Copy link
Contributor

External libraries build test

LibraryESP32ESP32C3ESP32S2ESP32S3
Adafruit NeoPixel1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ArduinoBLE1 ✅ -> 1 ✅1 ✅ -> 1 ✅N/A1 ✅ -> 1 ✅
ESP32Servo1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ESPAsyncWebServer3 ✅ 1⚠️ -> 3 ✅ 1⚠️4 ❌ -> 4 ❌3 ✅ 1⚠️ -> 3 ✅ 1⚠️3 ✅ 1⚠️ -> 3 ✅ 1⚠️
FastLED1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
IRremote1⚠️ -> 1⚠️1 ❌ -> 1 ❌1 ✅ -> 1 ✅1 ✅ -> 1 ✅
MFRC5221 ❌ -> 1 ✅1 ❌ -> 1 ✅1 ❌ -> 1 ✅1 ❌ -> 1 ✅
WS2812FX1 ❌ -> 1 ❌1 ❌ -> 1 ❌1 ❌ -> 1 ❌1 ❌ -> 1 ❌

@VojtechBartoskaVojtechBartoska added this to the2.0.9 milestoneMay 3, 2023
@github-actions
Copy link
Contributor

External libraries build test

LibraryESP32ESP32C3ESP32S2ESP32S3
Adafruit NeoPixel1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ArduinoBLE1 ✅ -> 1 ✅1 ✅ -> 1 ✅N/A1 ✅ -> 1 ✅
ESP32Servo1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
ESPAsyncWebServer3 ✅ 1⚠️ -> 3 ✅ 1⚠️4 ❌ -> 4 ❌3 ✅ 1⚠️ -> 3 ✅ 1⚠️3 ✅ 1⚠️ -> 3 ✅ 1⚠️
FastLED1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
IRremote1⚠️ -> 1⚠️1 ❌ -> 1 ❌1 ✅ -> 1 ✅1 ✅ -> 1 ✅
MFRC5221 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅
WS2812FX1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅1 ✅ -> 1 ✅

@me-no-devme-no-dev merged commit628b668 intoespressif:masterMay 3, 2023
@dok-netdok-net deleted the fix_8108 branchMay 3, 2023 19:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@mrengineer7777mrengineer7777mrengineer7777 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib_testRun External Libraries TestPriority: High 🗻Issues with high priority which needs to be solved first.

Projects

Milestone

2.0.9

Development

Successfully merging this pull request may close these issues.

Compile error under 2.0.8 if library function explicitly returns const __FlashStringHelper * from F() macro

6 participants

@dok-net@CLAassistant@me-no-dev@tueddy@mrengineer7777@VojtechBartoska
[8]ページ先頭
©2009-2025 Movatter.jp