- Notifications
You must be signed in to change notification settings - Fork7.8k
Changed type of LEDC frequency from double to uint32_t#6570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Collaborator
mrengineer7777 commentedApr 14, 2022
Makes sense to me. Floating point on embedded systems can be a real performance killer, unless the processor has a built in FPU. |
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull requestApr 21, 2022
* Delete stale.yml* IDF release/v4.4 b8050b365e (espressif#6594)* Update camera example to support face detection and recognition (espressif#6603)Fixes:espressif#6508* Change pinMode OUTPUT to INPUT_OUTPUT (espressif#6602)* Change OUTPUT to INPUT_OUTPUTTo match the official Arduino API.* Changed type of LEDC frequency from double to uint32_t (espressif#6570)* BUGFIX: FS read + speed improvements for SD (espressif#6569)* Revert "Edited VFSFileImpl::read to use both read/fread (espressif#6456)"This reverts commit7b89b39.* Added default file buffer size + function to change it by user* workflows/publish.yml: Run the workflow on success and failure only. (espressif#6531)* workflows/publish.yml: Run the workflow on success and failure only.This prevents trying to run when the trigger was cancelled or skipped.In these cases there will be no event file to upload.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* scripts/sketch_utils.sh: Move the logic that gets the build dir afterthe part that retrieves the arguments.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* workflows/hil.yml: Update the HIL runners tags.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* workflows/hil.yml: Remove the Check Artifacts step. That was onlyuseful for debugging.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* Pull request/Issue Templates and Readme update (espressif#6577)* Templates and readme* Templates_and_readme* Delete libraries/RainMaker directory* Delete tools/sdk/esp32/include/esp_rainmaker directory* Delete tools/sdk/esp32s2/include/esp_rainmaker directory* Delete tools/sdk/esp32s3/include/esp_rainmaker directory* Delete tools/sdk/esp32c3/include/esp_rainmaker directoryCo-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>Co-authored-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull requestApr 24, 2022
* Delete stale.yml* IDF release/v4.4 b8050b365e (espressif#6594)* Update camera example to support face detection and recognition (espressif#6603)Fixes:espressif#6508* Change pinMode OUTPUT to INPUT_OUTPUT (espressif#6602)* Change OUTPUT to INPUT_OUTPUTTo match the official Arduino API.* Changed type of LEDC frequency from double to uint32_t (espressif#6570)* BUGFIX: FS read + speed improvements for SD (espressif#6569)* Revert "Edited VFSFileImpl::read to use both read/fread (espressif#6456)"This reverts commit7b89b39.* Added default file buffer size + function to change it by user* workflows/publish.yml: Run the workflow on success and failure only. (espressif#6531)* workflows/publish.yml: Run the workflow on success and failure only.This prevents trying to run when the trigger was cancelled or skipped.In these cases there will be no event file to upload.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* scripts/sketch_utils.sh: Move the logic that gets the build dir afterthe part that retrieves the arguments.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* workflows/hil.yml: Update the HIL runners tags.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* workflows/hil.yml: Remove the Check Artifacts step. That was onlyuseful for debugging.Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>* Pull request/Issue Templates and Readme update (espressif#6577)Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>Co-authored-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
TheNitek added a commit to TheNitek/arduino-esp32 that referenced this pull requestDec 21, 2022
API has changed withespressif#6570
me-no-dev pushed a commit that referenced this pull requestDec 21, 2022
* Update ledc.rstAPI has changed with#6570* Update ledc.rstFix whitespaceCo-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed type of LEDC frequency from double to uint32_t because that the default type of frequency in ESP-IDF.
There is not support fro decimal numbers in LEDC in ESP-IDF.
Impact
None.
Related links
Closes#6550