Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feature(matter): improves Matter testing/status functions and documentation#12140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 28 commits intomasterfromfeature/matter_test_improvement
Dec 17, 2025

Conversation

@SuGlider
Copy link
Collaborator

@SuGliderSuGlider commentedDec 14, 2025•
edited
Loading

Description of Change

This PR improves and adds some new Matter network and status functions as well as the documentation:
1- Adds the necessary Arduino settings and IDE options in order to build it and upload the sketch.
2- Adds new functions to verify if WiFi (STA and AP), Thread and BLE Commissioning are enabled in the configuration.
3- Adds the list of examples with a short description to the main documentation.
4- Adds necessary IDE building option to all example's README.md files
5- Adds a new exmaple that demonstrates the Matter status and feature test functions.
6- Fixes incorrect example name and terms Windows Blind --> Blinds
7- Fixes documentation APIisWi-FiConnected() -->isWiFiConnected()

Added new Matter Functions:

// Network and Commissioning Capability Queries// These methods check both hardware support (SOC capabilities) and Matter configurationstaticboolisWiFiStationEnabled();// Check if WiFi Station mode is supported and enabledstaticboolisWiFiAccessPointEnabled();// Check if WiFi AP mode is supported and enabledstaticboolisThreadEnabled();// Check if Thread network is supported and enabledstaticboolisBLECommissioningEnabled();// Check if BLE commissioning is supported and enabled

Fixes implementation ofstatic bool isThreadConnected() Matter class method.

Test Scenarios

Tested using the provided example for the ESP32-S2, ESP32-C6, ESP32-C3 and ESP32-H2.

Related links

Closes#12139
Related to#11965

@SuGliderSuGlider self-assigned thisDec 14, 2025
@SuGliderSuGlider added the Area: MatterIssues and Feature Request about Matter Protocol labelDec 14, 2025
@SuGliderSuGlider added this to the3.3.0 milestoneDec 14, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedDec 14, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"fix(CI): Vale check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): Vale check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): Vale check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): docs check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): docs check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): docs check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): docs check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(CI): docs check":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.
  • the commit message"fix(matter): typo":
    • summary looks too short
  • the commit message"fix(matter_docs): typo":
    • summary looks too short
  • the commit message"fix(matter_docs): typo":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstf376a8d

@github-actions
Copy link
Contributor

github-actionsbot commentedDec 14, 2025•
edited
Loading

Test Results

 90 files   90 suites   31m 4s ⏱️
 66 tests  56 ✅ 0 💤 10 ❌
675 runs  655 ✅ 0 💤 20 ❌

For more details on these failures, seethis check.

Results for commitf376a8d.

♻️ This comment has been updated with latest results.

@SuGliderSuGlider moved this fromTodo toIn Progress inArduino ESP32 Core Project RoadmapDec 14, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedDec 14, 2025•
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50⚠️ +300.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C60⚠️ +360.000.00000.000.00
ESP32H20⚠️ +300.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterColorLight00--0000000000
libraries/Matter/examples/MatterCommissionTest00--0000000000
libraries/Matter/examples/MatterComposedLights00--0000000000
libraries/Matter/examples/MatterContactSensor00--0000000000
libraries/Matter/examples/MatterDimmableLight00--0000000000
libraries/Matter/examples/MatterDimmablePlugin00--0000000000
libraries/Matter/examples/MatterEnhancedColorLight00--0000000000
libraries/Matter/examples/MatterEvents00--0000000000
libraries/Matter/examples/MatterFan00--0000000000
libraries/Matter/examples/MatterHumiditySensor00--0000000000
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs⚠️ +300--0000⚠️ +360⚠️ +30000
libraries/Matter/examples/MatterMinimum00--0000000000
libraries/Matter/examples/MatterOccupancySensor00--0000000000
libraries/Matter/examples/MatterOnIdentify00--0000000000
libraries/Matter/examples/MatterOnOffLight00--0000000000
libraries/Matter/examples/MatterOnOffPlugin00--0000000000
libraries/Matter/examples/MatterPressureSensor00--0000000000
libraries/Matter/examples/MatterRainSensor00--0000000000
libraries/Matter/examples/MatterSimpleBlinds--------------
libraries/Matter/examples/MatterSmartButton00--0000000000
libraries/Matter/examples/MatterStatus--------------
libraries/Matter/examples/MatterTemperatureControlledCabinet00--0000000000
libraries/Matter/examples/MatterTemperatureControlledCabinetLevels00--0000000000
libraries/Matter/examples/MatterTemperatureLight00--0000000000
libraries/Matter/examples/MatterTemperatureSensor00--0000000000
libraries/Matter/examples/MatterThermostat00--0000000000
libraries/Matter/examples/MatterWaterFreezeDetector00--0000000000
libraries/Matter/examples/MatterWaterLeakDetector00--0000000000
libraries/Matter/examples/MatterWindowCovering00--0000000000

@SuGlider
Copy link
CollaboratorAuthor

@lucasssvaz - Wokwi fails with the SD Card unity test.

Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR enhances the Matter library by adding capability query functions to check enabled features and network support, fixes the Thread connection status implementation, and significantly improves documentation across all Matter examples. The changes enable developers to programmatically determine which Matter features are available on their hardware and configuration.

  • Adds four new capability query functions to check WiFi Station, WiFi AP, Thread, and BLE commissioning support
  • Fixes theisThreadConnected() implementation to use the correct ConnectivityMgr API
  • Adds comprehensive building and flashing instructions to all example README files
  • Creates a new MatterStatus example demonstrating the capability query functions

Reviewed changes

Copilot reviewed 35 out of 37 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
libraries/Matter/src/Matter.hAdds declarations for four new capability query methods and removes conditional compilation directives around connection status methods
libraries/Matter/src/Matter.cppImplements new capability query functions checking both hardware support and Matter configuration; fixes isThreadConnected() to use IsThreadAttached(); simplifies isDeviceConnected() logic
libraries/Matter/keywords.txtRegisters new capability query functions (isBLECommissioningEnabled, isThreadEnabled, isWiFiAccessPointEnabled, isWiFiStationEnabled) as keywords
libraries/Matter/examples/MatterStatus/MatterStatus.inoNew example demonstrating capability queries and connection status monitoring with periodic reporting
libraries/Matter/examples/MatterStatus/README.mdComprehensive documentation for the new MatterStatus example including supported targets, features, and usage instructions
libraries/Matter/examples/MatterStatus/ci.ymlCI configuration for MatterStatus example specifying partition scheme and Matter data model requirement
libraries/Matter/examples/*/README.mdAdds standardized building/flashing instructions (partition scheme and erase flash settings) to 22 existing example README files
docs/en/matter/matter.rstAdds building/flashing prerequisites section with screenshots, updates Matter class method list, and adds comprehensive examples catalog with descriptions and GitHub links
docs/_static/matter_partition_scheme.pngScreenshot showing partition scheme selection in Arduino IDE
docs/_static/matter_erase_flash.pngScreenshot showing erase flash option in Arduino IDE

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

SuGliderand others added3 commitsDecember 14, 2025 18:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider
Copy link
CollaboratorAuthor

On mobile, can't check, please ensure no hard dependence on specific network stack, f.ex wifi, thread, or ethernet.

@Gunni - Please elaborate more about your comment.
The Mobile APP (Alexa, Apple Home, Google HA etc) will follow whatever the Matter Accessory defines (ESP32 device implementation).

@Gunni
Copy link

Sorry, it just meant that I was on my phone when making that comment.

SuGlider reacted with thumbs up emoji

Copy link
Member

@lucasssvazlucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@me-no-devme-no-dev added the Status: Pending MergePull Request is ready to be merged labelDec 16, 2025
@github-actionsgithub-actionsbot added the Status: Pre-commit fixes required ⚠️The pre-commit bot can't fix the issues automatically. Please fix the issues manually. labelDec 16, 2025
@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actions
Copy link
Contributor

⚠️ Pre-commit Hooks Failed

Some pre-commit hooks failed and require manual fixes. Please see the detailed error report below.

What to do:

  1. 📋View the detailed error report to see which hooks failed
  2. 🔧 Fix the issues locally in your code
  3. 💾 Commit and push your changes
  4. 🔄 The hooks will run again automatically

Need help? Ask in the comments below.

@github-actionsgithub-actionsbot removed the Status: Pre-commit fixes required ⚠️The pre-commit bot can't fix the issues automatically. Please fix the issues manually. labelDec 17, 2025
@me-no-devme-no-dev merged commit295ff48 intomasterDec 17, 2025
76 of 80 checks passed
@me-no-devme-no-dev deleted the feature/matter_test_improvement branchDecember 17, 2025 08:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@pedrominatelpedrominatelpedrominatel approved these changes

@me-no-devme-no-devme-no-dev approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YAwaiting requested review from P-R-O-C-H-Y

Assignees

@SuGliderSuGlider

Labels

Area: MatterIssues and Feature Request about Matter ProtocolStatus: Pending MergePull Request is ready to be merged

Projects

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Implement theisThreadConnected method

6 participants

@SuGlider@Gunni@pedrominatel@me-no-dev@lucasssvaz
[8]ページ先頭
©2009-2025 Movatter.jp