Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(network): Fix getting fallback DNS server#12013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intoespressif:masterfromszerwi:fix/network_dns
Nov 12, 2025

Conversation

@szerwi
Copy link
Contributor

Description of Change

  • Fix getting fallback DNS server address usingNetworkInterface::dnsIP(uint8_t dns_no) function. Until now it only allowed to get main and backup servers.
  • Remove magic number inNetworkInterface::dnsIP(uint8_t dns_no, IPAddress ip) function.

Test Scenarios

Tested with arduino-esp32 v3.3.3 on ESP32 with WiFi STA, ETH and PPP.

Related links

- Fix getting fallback DNS server using NetworkInterface::dnsIP() getter- Remove magic number from NetworkInterface::dnsIP() setter
@github-actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello szerwi, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against893dba5

@github-actions
Copy link
Contributor

Test Results

 76 files   76 suites   16m 53s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit893dba5.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50⚠️ +20.000.00000.000.00
ESP32P40⚠️ +20.000.00000.000.00
ESP32S3💚 -4⚠️ +40.000.00000.000.00
ESP32S2💚 -12⚠️ +40.000.00000.000.00
ESP32C30⚠️ +20.000.00000.000.00
ESP32C60⚠️ +20.000.00000.000.00
ESP32H20⚠️ +20.000.00000.000.00
ESP32💚 -4⚠️ +160.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/AsyncUDP/examples/AsyncUDPClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/AsyncUDP/examples/AsyncUDPMulticastServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/AsyncUDP/examples/AsyncUDPServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/DNSServer/examples/CaptivePortal⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--⚠️ +160
libraries/ESP32/examples/Time/SimpleTime⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/ESP_NOW/examples/ESP_NOW_Network⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/ESP_NOW/examples/ESP_NOW_Serial⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/ESPmDNS/examples/mDNS-SD_Extended⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/ESPmDNS/examples/mDNS_Web_Server⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +20⚠️ +200000⚠️ +20⚠️ +20⚠️ +2000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +20⚠️ +200000⚠️ +20⚠️ +20⚠️ +2000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/FFat/examples/FFat_time⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/Authorization⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/BasicHttpClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/BasicHttpsClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/CustomHeaders⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/HTTPClientEnterprise⚠️ +20--00⚠️ +40⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/ReuseConnection⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPClient/examples/StreamHttpClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--⚠️ +40
libraries/HTTPUpdate/examples/httpUpdate⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPUpdate/examples/httpUpdateSecure⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/HTTPUpdateServer/examples/WebUpdater⚠️ +20⚠️ +2000⚠️ +40⚠️ +20⚠️ +20--00
libraries/Insights/examples/DiagnosticsSmokeTest⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/Insights/examples/MinimalDiagnostics⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/LittleFS/examples/LITTLEFS_time⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Matter/examples/MatterColorLight00--000000000000
libraries/Matter/examples/MatterCommissionTest00--000000000000
libraries/Matter/examples/MatterComposedLights00--000000000000
libraries/Matter/examples/MatterContactSensor00--00⚠️ +4000000000
libraries/Matter/examples/MatterDimmableLight00--000000000000
libraries/Matter/examples/MatterEnhancedColorLight00--000000000000
libraries/Matter/examples/MatterEvents00--000000000000
libraries/Matter/examples/MatterFan00--000000000000
libraries/Matter/examples/MatterHumiditySensor00--0000000000⚠️ +40
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00--000000000000
libraries/Matter/examples/MatterMinimum00--000000000000
libraries/Matter/examples/MatterOccupancySensor00--000000000000
libraries/Matter/examples/MatterOnIdentify00--0000000000⚠️ +120
libraries/Matter/examples/MatterOnOffLight00--000000000000
libraries/Matter/examples/MatterOnOffPlugin00--000000000000
libraries/Matter/examples/MatterPressureSensor00--000000000000
libraries/Matter/examples/MatterSmartButton00--000000000000
libraries/Matter/examples/MatterTemperatureLight00--000000000000
libraries/Matter/examples/MatterTemperatureSensor00--000000000000
libraries/Matter/examples/MatterThermostat00--0000000000💚 -40
libraries/NetBIOS/examples/ESP_NBNST⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--💚 -40
libraries/NetworkClientSecure/examples/WiFiClientInsecure⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientPSK⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientSecure⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/PPP/examples/PPP_Basic⚠️ +20⚠️ +200000⚠️ +20⚠️ +20⚠️ +2000
libraries/PPP/examples/PPP_WIFI_BRIDGE⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/RainMaker/examples/RMakerCustom⚠️ +20--0000⚠️ +20⚠️ +20----
libraries/RainMaker/examples/RMakerCustomAirCooler⚠️ +20--0000⚠️ +20⚠️ +20----
libraries/RainMaker/examples/RMakerSonoffDualR3⚠️ +20--0000⚠️ +20⚠️ +20----
libraries/RainMaker/examples/RMakerSwitch⚠️ +20--0000⚠️ +20⚠️ +20----
libraries/SD/examples/SD_time⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/SPIFFS/examples/SPIFFS_time⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Update/examples/AWS_S3_OTA_Update⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Update/examples/HTTPS_OTA_Update⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Update/examples/HTTP_Client_AES_OTA_Update⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Update/examples/HTTP_Server_AES_OTA_Update⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/Update/examples/OTAWebUpdater⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/AdvancedWebServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/ChunkWriting⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/FSBrowser⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/Filters⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HelloServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpAdvancedAuth⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpAuthCallback⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpAuthCallbackInline⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpBasicAuth⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpBasicAuthSHA1⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/Middleware⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/MultiHomedServers⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/PathArgServer⚠️ +20⚠️ +20⚠️ +4000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/SDWebServer⚠️ +20⚠️ +20💚 -4000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/SimpleAuthentification⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/UploadHugeFile⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/WebServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WebServer/examples/WebUpdate⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/FTM/FTM_Initiator⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/FTM/FTM_Responder⚠️ +20⚠️ +2000⚠️ +40⚠️ +20⚠️ +20--00
libraries/WiFi/examples/SimpleWiFiServer⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WPS⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiAccessPoint⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiBlueToothSwitch⚠️ +20--00--⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClientBasic⚠️ +20⚠️ +20💚 -4000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClientConnect⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClientEnterprise⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClientEvents⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiClientStaticIP⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiExtender⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiIPv6⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiMulti⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiMultiAdvanced⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiScan⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiScanAsync⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiScanDualAntenna⚠️ +20⚠️ +20⚠️ +4000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiScanTime⚠️ +20⚠️ +2000💚 -120⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiSmartConfig⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/WiFi/examples/WiFiTelnetToSerial⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--💚 -40
libraries/WiFi/examples/WiFiUDPClient⚠️ +20⚠️ +200000⚠️ +20⚠️ +20--00
libraries/WiFiProv/examples/WiFiProv⚠️ +20--0000⚠️ +20⚠️ +20--00
libraries/Zigbee/examples/Zigbee_Gateway⚠️ +20--0000⚠️ +20----00
libraries/Ethernet/examples/ETH_TLK110--⚠️ +20----------00
libraries/SD_MMC/examples/SDMMC_time--⚠️ +2000--------00
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----00⚠️ +40------00
ESP32/examples/Camera/CameraWebServer (3)----00----------
libraries/Ethernet/examples/ETH_LAN8720--------------00

@me-no-devme-no-dev added the Status: Pending MergePull Request is ready to be merged labelNov 12, 2025
@me-no-devme-no-dev merged commit96520bc intoespressif:masterNov 12, 2025
94 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szerwi@me-no-dev@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp