Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(ci): Fix IDF examples compilation when changing source files#12001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lucasssvaz merged 1 commit intoespressif:masterfromlucasssvaz:fix/idf_affected
Nov 7, 2025

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This pull request introduces a targeted enhancement to the logic for determining affected sketches in component mode. The main change ensures that when any source or header file (excluding.ino files) within thecores/ orlibraries/ directories is modified, all IDF component examples are automatically flagged for recompilation. This helps maintain build integrity in response to low-level code changes.

Component mode logic improvements:

  • Added a check to recompile all IDF component examples if any source or header file (except.ino files) incores/ orlibraries/ is changed, ensuring comprehensive coverage for critical component updates.

Test Scenarios

Tested locally

@lucasssvazlucasssvaz self-assigned thisNov 7, 2025
@lucasssvazlucasssvaz added the Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure. labelNov 7, 2025
@github-actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against93562ff

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Server000000--00000000
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecure000000000000--00
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------

@lucasssvazlucasssvaz added the Status: Pending MergePull Request is ready to be merged labelNov 7, 2025
@lucasssvazlucasssvaz merged commit0ae0838 intoespressif:masterNov 7, 2025
55 checks passed
@lucasssvazlucasssvaz deleted the fix/idf_affected branchNovember 11, 2025 14:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev approved these changes

Assignees

@lucasssvazlucasssvaz

Labels

Status: Pending MergePull Request is ready to be mergedType: CI & TestingRelated to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasssvaz@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp