Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(ble): Fix broken functions and add IRK retrieval#11948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 5 commits intoespressif:masterfromlucasssvaz:fix/ble
Nov 3, 2025

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This PR adds the peer's IRK information and fixes the following issues:

  • Deadlock during authentication under certain conditions
  • Deinit function not working as expected
  • Race condition for notifications

Test Scenarios

Tested locally

Related links

Closes#11938
Closes#11906

@lucasssvazlucasssvaz self-assigned thisOct 25, 2025
@lucasssvazlucasssvaz added the Area: BLEIssues related to BLE labelOct 25, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedOct 25, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstb35faa8

@github-actions
Copy link
Contributor

github-actionsbot commentedOct 25, 2025
edited
Loading

Test Results

 76 files   76 suites   15m 13s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commitb35faa8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actionsbot commentedOct 25, 2025
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50‼️ +5K0.00⚠️ +0.72000.000.00
ESP32P40‼️ +5K0.00⚠️ +0.71000.000.00
ESP32S30‼️ +5K0.00⚠️ +0.80000.000.00
ESP32C30‼️ +5K0.00⚠️ +0.90000.000.00
ESP32C60‼️ +6K0.00⚠️ +0.78000.000.00
ESP32H20‼️ +5K0.00⚠️ +0.76000.000.00
ESP320‼️ +5K0.00⚠️ +0.50000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Beacon_Scanner⚠️ +2500⚠️ +2500⚠️ +3560⚠️ +2480⚠️ +2400⚠️ +2420⚠️ +6720
libraries/BLE/examples/Client⚠️ +2480⚠️ +2480⚠️ +3720⚠️ +2480⚠️ +2460⚠️ +2400⚠️ +8760
libraries/BLE/examples/Client_secure_static_passkey‼️ +5K0‼️ +5K0‼️ +4K0‼️ +5K0‼️ +5K0‼️ +5K0‼️ +5K0
libraries/BLE/examples/EddystoneTLM_Beacon⚠️ +2460⚠️ +2380⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6720
libraries/BLE/examples/EddystoneURL_Beacon⚠️ +2380⚠️ +2460⚠️ +3560⚠️ +2460⚠️ +2380⚠️ +2380⚠️ +6560
libraries/BLE/examples/Notify⚠️ +2380⚠️ +2480⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6480
libraries/BLE/examples/Scan⚠️ +2380⚠️ +2460⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6600
libraries/BLE/examples/Server⚠️ +2380⚠️ +2460⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6600
libraries/BLE/examples/Server_multiconnect⚠️ +2480⚠️ +2400⚠️ +3560⚠️ +2480⚠️ +2380⚠️ +2400⚠️ +6480
libraries/BLE/examples/Server_secure_authorization⚠️ +2380--⚠️ +3720⚠️ +2460⚠️ +2460⚠️ +2460--
libraries/BLE/examples/Server_secure_static_passkey‼️ +5K0‼️ +5K0‼️ +5K0‼️ +5K0‼️ +6K0‼️ +5K0‼️ +5K0
libraries/BLE/examples/UART⚠️ +2480⚠️ +2380⚠️ +3720⚠️ +2460⚠️ +2400⚠️ +2400⚠️ +6440
libraries/BLE/examples/Write⚠️ +2480⚠️ +2400⚠️ +3720⚠️ +2460⚠️ +2400⚠️ +2400⚠️ +6600
libraries/BLE/examples/iBeacon⚠️ +2460⚠️ +2380⚠️ +3640⚠️ +2480⚠️ +2380⚠️ +2380⚠️ +6440

@lucasssvazlucasssvaz marked this pull request as draftOctober 27, 2025 03:24
@lucasssvazlucasssvaz added the Status: In Progress ⚠️Issue is in progress labelOct 27, 2025
@lucasssvazlucasssvaz marked this pull request as ready for reviewOctober 28, 2025 16:22
@lucasssvazlucasssvaz added Status: Review neededIssue or PR is awaiting review and removed Status: In Progress ⚠️Issue is in progress labelsOct 28, 2025
@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsNov 3, 2025
@me-no-devme-no-dev merged commit56a2245 intoespressif:masterNov 3, 2025
55 of 56 checks passed
@lucasssvazlucasssvaz deleted the fix/ble branchNovember 3, 2025 11:45
@lucasssvazlucasssvaz mentioned this pull requestNov 14, 2025
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

@SuGliderSuGliderAwaiting requested review from SuGliderSuGlider is a code owner

Assignees

@lucasssvazlucasssvaz

Labels

Area: BLEIssues related to BLEStatus: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

3 participants

@lucasssvaz@me-no-dev@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp