Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(board): Fix wESP32 board config with new options#11879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 3 commits intoespressif:masterfromxorbit:fix-wesp32-board-config
Oct 6, 2025

Conversation

@xorbit
Copy link
Contributor

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Pleaseupdate relevant Documentation if applicable
  4. Please checkContributing guide
  5. Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

  • Provide flash size option to choose 4MB flash (rev 5 and below) or 16MB flash (default, rev 7 and higher).
  • Provide appropriate partition scheme options to effectively use either 4MB or 16MB flash sizes.
  • Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and higher default).

Test Scenarios

Tested on Arduino 2.3.6 locally with wESP32 rev 8 board.

- Provide flash size option to choose 4MB flash (rev 5 and below)  or 16MB flash (default, rev 7 and higher).- Provide appropriate partition scheme options to effectively us  either 4MB or 16MB flash sizes.- Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and  higher).
@github-actions
Copy link
Contributor

github-actionsbot commentedSep 27, 2025•
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello xorbit, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against935bf7c

@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelSep 29, 2025
#defineETH_PHY_ADDR 0
#defineETH_PHY_POWER -1
#defineETH_PHY_MDC 16
#defineETH_PHY_MDIO 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about having also#define ETH_PHY_TYPE_REV4 ETH_PHY_LAN8720 in case someone uses the old revision to keep backward compatibility.

Copy link
ContributorAuthor

@xorbitxorbitSep 29, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In my examples, I have usually called out just setting all parameters:
https://wesp32.com/software/#arduino-esp32

With the change in this PR, users now could just useETH.begin() for any wESP32 sold in the last 4 years.

The only revisions ever sold are rev 3, 4 and 5 with LAN8720, sold for about 3 years (2018 ~ 2021), and rev 7 and 8 with RTL8201, sold the last 4 years (2021 ~ present). I'm not sure how to clearly communicate what another define would be for exactly. It's not just revision 4, it's 3, 4 and 5 you'd use LAN8720 for. I don't see how any new#define we'd come up with would be clearer than to just say "this board needs LAN8720" and use theETH_PHY_LAN8720 name directly.

P-R-O-C-H-Y reacted with thumbs up emoji
@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelOct 6, 2025
@me-no-devme-no-dev merged commit3af560a intoespressif:masterOct 6, 2025
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

+1 more reviewer

@wootangkwootangkwootangk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xorbit@P-R-O-C-H-Y@wootangk@me-no-dev
[8]ページ先頭
©2009-2025 Movatter.jp