Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Migrate to wokwi-py-client (update pytest-embedded and esptool)#11863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@JakubAndrysek
Copy link
Collaborator

@JakubAndrysekJakubAndrysek commentedSep 19, 2025•
edited
Loading

Description of Change

Migrate from Wokwi CLI to the wokwi-python-client. For this I have updated the dependencies and modified the code to use for testing (GPIO only).

  • For using the wokwi-python-client, I have updated esptool to version 5.1.0.
  • I have also updated pytest-embedded-* to version 2.0.0a1. This is still in alpha, but I am investigating when a stable version will be available.
  • For functional testing, I have also temporarily disabled installation from ourExtra index since there are not those packages available.

Test Scenarios

Tested in my GitHub Actions -link.

Before merging

  • Revert--extra-index-url tohttps://dl.espressif.com/pypi
  • Updatepytest-embedded-* to stable version when available

@github-actions
Copy link
Contributor

github-actionsbot commentedSep 19, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"change(workflow): Remove extra index URL from pip install command in Wokwi tests - for testing":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello JakubAndrysek, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against237406e

@github-actions
Copy link
Contributor

github-actionsbot commentedSep 19, 2025•
edited
Loading

Test Results

 76 files   76 suites   13m 51s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit237406e.

♻️ This comment has been updated with latest results.

@JakubAndrysek
Copy link
CollaboratorAuthor

There is the link to my updated CI - PR test:JakubAndrysek#14. Actions at the end of the PR.

Copy link
Member

@pedrominatelpedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@me-no-dev
Copy link
Member

@lucasssvaz PTAL

@me-no-devme-no-dev added the Status: Pending MergePull Request is ready to be merged labelSep 25, 2025
@me-no-devme-no-dev merged commit372ba6a intoespressif:masterSep 25, 2025
50 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pedrominatelpedrominatelpedrominatel approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JakubAndrysek@me-no-dev@pedrominatel@lucasssvaz@P-R-O-C-H-Y
[8]ページ先頭
©2009-2025 Movatter.jp