NotificationsYou must be signed in to change notification settings
Fork7.8k
Star15.9k

Update pins_arduino.h for lolin_c3_pico to define LED as RGB rather than the default GRB#11851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 3 commits intoespressif:masterfrommitra42:patch-2

Sep 22, 2025

Merged

Update pins_arduino.h for lolin_c3_pico to define LED as RGB rather than the default GRB#11851

me-no-dev merged 3 commits intoespressif:masterfrommitra42:patch-2

Sep 22, 2025

Conversation

Copy link

Contributor

mitra42 commentedSep 17, 2025

Description of Change

Please describe your proposed Pull Request and it's impact.

On the lolin_c3_pico the LED is RGB, but RGB_BUILTIN_LED_COLOR_ORDER defaults to GRB which is correct for many Neopixel LEDs

Test Scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

Tested on Lolin C3 Pico - with Frugal_IoT system, looked carefully at call to rgbLedWrite which was correctly sending rgb in that order, BUT the LED was coming up the wrong color because of the default to presume the actual write to LED should be GRB.

I'm using PlatformIO with specific config

[env:sht30_lolin_c3_pico]platform = espressif32board = lolin_c3_mini board_build.variant = lolin_c3_picobuild_flags =     ${common.build_flags}    -D ARDUINO_LOLIN_C3_PICO ; if using C3_PICO use lolin_c3_mini as board and define herelib_compat_mode = strictboard_build.partitions = huge_app.csvlib_deps =     ${common.lib_deps}

Related links

Please provide links to related issue, PRs etc.
N/A
(eg. Closes #number of issue)

Update pins_arduino.h for lolin_c3_pico to define LED as RGB rather t…

879e14d

…han the default GRB

mitra42 requested a review fromP-R-O-C-H-Y as acode owner

September 17, 2025 12:04

Copy link

Contributor

github-actionsbot commentedSep 17, 2025•
edited
Loading

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"Update pins_arduino.h for lolin_c3_pico to define LED as RGB rather than the default GRB"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello mitra42, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against656cb0b