Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(board): add support for Silicognition ManT1S#11848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intoespressif:masterfromxorbit:add-mant1s-board
Sep 16, 2025

Conversation

@xorbit
Copy link
Contributor

Description of Change

Add new board Silicognition ManT1S:https://www.crowdsupply.com/silicognition/mant1s

  • Add board configuration toboards.txt.
  • Add pin definitions and T1S Ethernet config tovariants/mant1s.

mant1s-angle-01

Test Scenarios

This requires LAN867x support so depends on#11843, which is not in any release. So it was tested onmaster on a prototype ManT1S rev 4. Works as expected with unmodified ETH_LAN8720 example, sincepins_arduino.h definesETH_PHY_MDC correctly for the ManT1S the config block on top of the example is ignored and uses the correct Ethernet definitions frompins_arduino.h instead.

Related links

Depends on#11843 and library built with the LAN867x supports this adds.

- Add board configuration to `boards.txt`- Add pin and Ethernet definitions to `variants/mant1s`
@CLAassistant
Copy link

CLAassistant commentedSep 16, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedSep 16, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello xorbit, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against67cd439

@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelSep 16, 2025
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelSep 16, 2025
@xorbit
Copy link
ContributorAuthor

I received a comment about the placement inboards.txt in my email but I can't see it here. This is a Silicognition board, so I put it right below the other Silicognition board, the wESP32.

P-R-O-C-H-Y reacted with thumbs up emoji

@P-R-O-C-H-Y
Copy link
Member

@xorbit All good, I have removed the comment, as the board above is from Silicognition. Missed that first time. Its ready to be merged ;)

xorbit reacted with thumbs up emoji

@me-no-devme-no-dev merged commite2254cc intoespressif:masterSep 16, 2025
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xorbit@CLAassistant@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp