Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(zigbee): Add lock in scanNetworks to avoid race condition#11792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intomasterfromfix/zigbee-network-scan
Sep 4, 2025

Conversation

@P-R-O-C-H-Y
Copy link
Member

Description of Change

Improvements to scan management and thread safety:

  • Added a check to prevent initiating a new scan if one is already in progress, logging a warning and returning early inZigbeeCore::scanNetworks (ZigbeeCore.cpp).
  • Wrapped the scan request call withesp_zb_lock_acquire andesp_zb_lock_release to ensure thread safety when starting a Zigbee network scan (ZigbeeCore.cpp).

Test Scenarios

Tested using the ScanNetworks example.

Related links

Closes#10879

@github-actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against91ba3b5

@github-actions
Copy link
Contributor

github-actionsbot commentedSep 3, 2025
edited
Loading

Test Results

 76 files   76 suites   13m 12s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit91ba3b5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Analog_Input_Output--------------
libraries/Zigbee/examples/Zigbee_Binary_Input--------------
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor--------------
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light--------------
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch--------------
libraries/Zigbee/examples/Zigbee_Contact_Switch--------------
libraries/Zigbee/examples/Zigbee_Dimmable_Light--------------
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor--------------
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase--------------
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor--------------
libraries/Zigbee/examples/Zigbee_Fan_Control--------------
libraries/Zigbee/examples/Zigbee_Gateway--------------
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor--------------
libraries/Zigbee/examples/Zigbee_OTA_Client--------------
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor--------------
libraries/Zigbee/examples/Zigbee_On_Off_Light--------------
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch--------------
libraries/Zigbee/examples/Zigbee_On_Off_Switch--------------
libraries/Zigbee/examples/Zigbee_PM25_Sensor--------------
libraries/Zigbee/examples/Zigbee_Power_Outlet--------------
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor--------------
libraries/Zigbee/examples/Zigbee_Range_Extender--------------
libraries/Zigbee/examples/Zigbee_Scan_Networks--------------
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy--------------
libraries/Zigbee/examples/Zigbee_Temperature_Sensor--------------
libraries/Zigbee/examples/Zigbee_Thermostat--------------
libraries/Zigbee/examples/Zigbee_Vibration_Sensor--------------
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor--------------
libraries/Zigbee/examples/Zigbee_Window_Covering--------------

@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsSep 4, 2025
@me-no-devme-no-dev merged commit3a6edd0 intomasterSep 4, 2025
107 of 110 checks passed
@me-no-devme-no-dev deleted the fix/zigbee-network-scan branchSeptember 4, 2025 06:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

Assignees

@P-R-O-C-H-YP-R-O-C-H-Y

Labels

Area: ZigbeeIssues and Feature Request about ZigbeeStatus: Pending MergePull Request is ready to be mergedType: Bug 🐛All bugs

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sporadic crashes when using Zigbee

3 participants

@P-R-O-C-H-Y@me-no-dev@lucasssvaz

[8]ページ先頭

©2009-2025 Movatter.jp