NotificationsYou must be signed in to change notification settings
Fork7.8k
Star15.9k

variant lilyho_t3_s3_sx127x duplicates LORA_BUSY - deleting one of them#11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 1 commit intoespressif:masterfrommitra42:patch-1

Aug 22, 2025

Merged

variant lilyho_t3_s3_sx127x duplicates LORA_BUSY - deleting one of them#11678

me-no-dev merged 1 commit intoespressif:masterfrommitra42:patch-1

Aug 22, 2025

Conversation

Copy link

Contributor

mitra42 commentedJul 31, 2025

There were two definitions of LORA_BUSY generating a lot of unneccessary warnings.

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Description of Change

Please describe your proposed Pull Request and it's impact.

The file contains two definitions of LORA_BUSY - one as 33, and the other as ```
#define LORA_BUSY LORA_DIO1

Where DIO1 is also defined as 33.  This causes lots of un-useful warning messages from the duplicated definition. ## Tests scenariosPlease describe on what Hardware and Software combinations you have tested this Pull Request and how.Tested on my Lilygo T3 S3, with this change ## Related linksNot applicable -  no issue posted.

variant lilyho_t3_s3_sx127x duplicates LORA_BUSY

e1822b3

There were two definitions of LORA_BUSY generating a lot of unneccessary warnings.

mitra42 requested a review fromP-R-O-C-H-Y as acode owner

July 31, 2025 03:56

Copy link

CLAassistant commentedJul 31, 2025•
edited
Loading

All committers have signed the CLA.

Copy link

Contributor

github-actionsbot commentedJul 31, 2025

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"variant lilyho_t3_s3_sx127x duplicates LORA_BUSY "`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello mitra42, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againste1822b3