Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(async): Update IP setup in AsyncUDP#11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfrombugfix/asyncudp_v6
Jul 8, 2025
Merged

Conversation

@me-no-dev
Copy link
Member

This pull request refactors theAsyncUDP class inAsyncUDP.cpp to simplify and standardize the handling of IP address types. The changes primarily replace conditional logic with more concise and consistent macros, improving readability and maintainability.

Refactoring for IP Address Handling:

  • AsyncUDP::listen: ReplacedIP_SET_TYPE_VAL withIP_SET_TYPE and usedIP_GET_TYPE to standardize the setting of IP address types for bothlocal_ip andremote_ip.
  • AsyncUDP::listenMulticast: Simplified the handling of IPv4 and IPv6 addresses by replacing conditional logic withIP_SET_TYPE andip_addr_set_any, reducing complexity and improving clarity.

Fixes:#11553

@github-actions
Copy link
Contributor

github-actionsbot commentedJul 8, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against60e70dc

@github-actions
Copy link
Contributor

github-actionsbot commentedJul 8, 2025
edited
Loading

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit60e70dc.

♻️ This comment has been updated with latest results.

@me-no-devme-no-dev added the Status: Review neededIssue or PR is awaiting review labelJul 8, 2025
@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/AsyncUDP/examples/AsyncUDPClient------------
libraries/AsyncUDP/examples/AsyncUDPMulticastServer------------
libraries/AsyncUDP/examples/AsyncUDPServer------------

@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsJul 8, 2025
@me-no-devme-no-dev merged commit241e257 intomasterJul 8, 2025
73 of 79 checks passed
@me-no-devme-no-dev deleted the bugfix/asyncudp_v6 branchJuly 8, 2025 13:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

class "ip4_addr" has no member "u_addr" error in AsyncUDP if IPv6 is disabled

4 participants

@me-no-dev@lucasssvaz@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp