Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Deneyap Kart v2#11545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 31 commits intoespressif:masterfromdeneyapkart:master
Jul 3, 2025
Merged

Add Deneyap Kart v2#11545

me-no-dev merged 31 commits intoespressif:masterfromdeneyapkart:master
Jul 3, 2025

Conversation

@DogushC
Copy link
Contributor

Please, add our new development board "Deneyap Kart v2".
Added pin definitions to "\variants\deneyapkartv2\pins_arduino.h"and also added the board configs and updated "boards.txt"
This board were tested with ESP32 v3.2.0 repo at Arduino IDE 2.3.5.
You can access pinoutson our github page.
Visit our store for all development kits.

P-R-O-C-H-Y reacted with thumbs up emoji
DogushCand others added24 commitsFebruary 16, 2023 11:52
Deleted soc_caps.h library and related commands at Deneyap Kart 1A v2, Deneyap Kart 1A, Deneyap Mini and Deneyap Mini v2.Added TX1 and RX1 pins and updated LED pin definition at all Devkits.Added BOOT (BT) pins at Deneyap Kart, Deneyap Kart 1A, Deneyap Mini and Deneyap Kart G.Changed D0 and D1 pin numbers at Deneyap Kart G.Changed D12, D13, D14, D15, PWM0 and PWM1 pin numbers at Deneyap Kart 1A v2.Added A8, T0, T1, T2, T3, T4, T5, T6, T7, T8, D16, D17, D18, D19, PWM2, PWM3, PWM4 and BAT pin numbers at Deneyap Kart 1A v2.Changed A2, A3, A4 (T0) and A5 (T1) pin numbers at Deneyap Kart and Deneyap Kart 1A.Renamed DA2 (DAC2) pin as DA0 (DAC0) and changed DAC1 and DAC2 pin numbers at Deneyap Mini and Deneyap Mini v2.
Updated board.txt of all Devkits
Remove Repeating Pin Definition
Remove repeating pin definitions of SPI, I2C and DAC.Update RGB LED definition for using digitalWrite() command with RGB LED.
Remove repeating pin definitions of LEDB, SPI, I2C and DAC.
Update RGB LED definition for using digitalWrite() command with RGB LED.
Fix broken links for external library test
Update UploadMode Config of Deneyap Kart 1A v2
Add pin definitions and configs of Deneyap Kart v2.
Hardware CDC is default now.
Fixed typo fault
@github-actions
Copy link
Contributor

github-actionsbot commentedJul 2, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Add Deneyap Kart v2":
    • summary looks empty
    • type/action looks empty
  • the commit message"Fix Pin Definition":
    • summary looks empty
    • type/action looks empty
  • the commit message"Fix broken links for external library test":
    • summary looks empty
    • type/action looks empty
  • the commit message"Fixed Annotations and Space":
    • summary looks empty
    • type/action looks empty
  • the commit message"Fixed build.board parameter":
    • summary looks empty
    • type/action looks empty
  • the commit message"Fixed typo fault":
    • summary looks empty
    • type/action looks empty
  • the commit message"Remove Repeating Pin Definition":
    • summary looks empty
    • type/action looks empty
  • the commit message"Remove Repeating Pin Definitions":
    • summary looks empty
    • type/action looks empty
  • the commit message"Remove unsupported partition options":
    • summary looks empty
    • type/action looks empty
  • the commit message"Removed unsupported Flash sizes and RAM type":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update RGB LED definition":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update UploadMode Config of Deneyap Kart 1A v2":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update UploadMode config":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message"Updated Pins of Devkits":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message"Updated board.txt of all Devkits":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello DogushC, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against8b9278e

@P-R-O-C-H-Y
Copy link
Member

@DogushC CI is failing:https://github.com/espressif/arduino-esp32/actions/runs/16027118868/job/45217808352?pr=11545#step:3:16
build.board parameter must be uppercase

DogushC reacted with thumbs up emoji

Fixed build.board parameter
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelJul 3, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Awaiting ResponseAwaiting a response from the author labelJul 3, 2025
Removed unsupported Flash sizes and RAM type from menu.
Remove unsupported partition options
@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Awaiting ResponseAwaiting a response from the author labelsJul 3, 2025
@P-R-O-C-H-Y
Copy link
Member

@DogushC Looks good to me now :)

DogushC reacted with hooray emoji

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commentedJul 3, 2025•
edited
Loading

Please fix the pre-commit errorshttps://github.com/espressif/arduino-esp32/actions/runs/16051424802/job/45294791890?pr=11545
For next time its better to allow maintainers to push changes -> recommit can fix it automatically (and ideally to not be master->master, but create a branch on your fork ;) )

DogushC reacted with thumbs up emoji

@P-R-O-C-H-Y
Copy link
Member

@DogushC We are planning to release now. If you fix within 30 minutes your board can get into 3.2.1 :)

@DogushC
Copy link
ContributorAuthor

@DogushC We are planning to release now. If you fix within 30 minutes your board can get into 3.2.1 :)

I couldn't catch it.

@me-no-devme-no-dev merged commit0b9c936 intoespressif:masterJul 3, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DogushC@P-R-O-C-H-Y@me-no-dev
[8]ページ先頭
©2009-2025 Movatter.jp