Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add FED4 board#11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 9 commits intoespressif:masterfromstrid3r21:master
Jul 2, 2025
Merged

Add FED4 board#11536

me-no-dev merged 9 commits intoespressif:masterfromstrid3r21:master
Jul 2, 2025

Conversation

strid3r21
Copy link
Contributor

@strid3r21strid3r21 commentedJul 1, 2025•
edited
Loading

Adding the FED4 board

Description of Change

Adding the FED4 board pin definitions and to boards.txt.

the FED4 is a small commercial product that university labs can use monitor feeding behaviors of mice.
Designed by my company Smart Bee Designs LLC

FED4
image001

The Fed4 is the next installment in the FED line (replacing the FED3)https://kravitzlab.com/research &https://open-ephys.org/fed3/fed3

Tests scenarios

Tested on 3.2.0 on Windows running through several sketches that functionally test the device.

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJul 1, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Added Fed 4 board":
    • summary looks empty
    • type/action looks empty
  • the commit message"added usb pid address":
    • summary looks empty
    • type/action looks empty
  • the commit message"fixed board.txt again":
    • summary looks empty
    • type/action looks empty
  • the commit message"fixed boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message"fixed typo: updated name to upper case":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello strid3r21, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against1b2825f

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y added Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. Status: Awaiting Responseawaiting a response from the author labelsJul 2, 2025
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@strid3r21 PTAL, also would be best to include some link to the product in the PR description.

@strid3r21
Copy link
ContributorAuthor

strid3r21 commentedJul 2, 2025•
edited
Loading

@strid3r21 PTAL, also would be best to include some link to the product in the PR description.

added links.

P-R-O-C-H-Y reacted with thumbs up emoji

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Awaiting Responseawaiting a response from the author labelsJul 2, 2025
@me-no-devme-no-dev merged commit33c8438 intoespressif:masterJul 2, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@strid3r21@P-R-O-C-H-Y@me-no-dev
[8]ページ先頭
©2009-2025 Movatter.jp