Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(board): add support for RAKwireless RAK3112#11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@DanielCao0
Copy link
Contributor

@DanielCao0DanielCao0 commentedJun 19, 2025•
edited
Loading

This pull request introduces support for the RAKWireless RAK3112 module by adding its configuration to theboards.txt file and defining its pin mappings inpins_arduino.h. The changes primarily focus on enabling compatibility with the RAK3112 hardware and providing the necessary settings for its operation.

RAK3112: ESP32S3+SX1262(LORA)

https://www.rakwireless.com/en-us
https://docs.rakwireless.com/product-categories/wisduo/rak3112-module/overview

New Board Support: RAKWireless RAK3112

Board Configuration:

  • Added a new entry for the RAKWireless RAK3112 inboards.txt, including upload settings, build configurations, and menu options such as PSRAM, core selection, USB mode, partition schemes, CPU frequency, flash mode, and debug levels.[1][2]

Pin Definitions:

  • Created a newpins_arduino.h file under thevariants/rakwireless_rak3112 directory. This file defines the pin mappings for the RAK3112, including USB VID/PID, LED pins, I2C pins, SPI pins, and LoRa module pins.

image

@CLAassistant
Copy link

CLAassistant commentedJun 19, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedJun 19, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Delete blank lines":
    • summary looks empty
    • type/action looks empty
  • the commit message"Delete the redundant configuration information in board.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message"Move the rak configuration information to the end of the boards.txt .":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message"Restore the incorrect modifications to board.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello DanielCao0, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against1744286

@DanielCao0DanielCao0 changed the titleFeat/support rakwireless rak3112Feat/support rakwireless rak3112Jun 19, 2025
@DanielCao0DanielCao0 changed the titleFeat/support rakwireless rak3112feat(board): add support for rakwireless rak3112Jun 19, 2025
@P-R-O-C-H-Y
Copy link
Member

Hi@DanielCao0, please mov the RAK board definitions to the end of the file as there is no other RAK board there. Thanks

@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelJun 19, 2025
@DanielCao0
Copy link
ContributorAuthor

DanielCao0 commentedJun 19, 2025•
edited
Loading

@P-R-O-C-H-Y Thank you , I have already moved the RAK board definitions to the end of the file as requested.
Please let me know if there’s anything else that needs to be adjusted. Thanks!

P-R-O-C-H-Y reacted with thumbs up emoji

@DanielCao0DanielCao0 changed the titlefeat(board): add support for rakwireless rak3112feat(board): add support for RAKwireless rak3112Jun 26, 2025
@DanielCao0DanielCao0 changed the titlefeat(board): add support for RAKwireless rak3112feat(board): add support for RAKwireless RAK3112Jun 26, 2025
@P-R-O-C-H-Y
Copy link
Member

@DanielCao0 Please resolve conflicts inboards.txt file.

DanielCao0 reacted with thumbs up emoji

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelJul 2, 2025
@me-no-devme-no-dev merged commit7f75e44 intoespressif:masterJul 2, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielCao0@CLAassistant@P-R-O-C-H-Y@me-no-dev@danielRAKwireless
[8]ページ先頭
©2009-2025 Movatter.jp