Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(test): Enhance NVS test#11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 5 commits intoespressif:masterfromJakubAndrysek:test_nvs
Jun 23, 2025
Merged

Conversation

@JakubAndrysek
Copy link
Collaborator

@JakubAndrysekJakubAndrysek commentedJun 18, 2025
edited
Loading

Description of Change

This pull request introduces enhancements to thetests/validation/nvs module, focusing on extending the functionality of the NVS (Non-Volatile Storage) validation and improving test coverage. The changes include adding support for more data types, implementing value incrementation, and updating the test cases accordingly.

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with Wokwi on all available chips.

@github-actions
Copy link
Contributor

github-actionsbot commentedJun 18, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against13aac76

@github-actions
Copy link
Contributor

github-actionsbot commentedJun 18, 2025
edited
Loading

Test Results

144 files  144 suites   48m 19s ⏱️
 43 tests  42 ✅ 0 💤  1 ❌
443 runs  422 ✅ 0 💤 21 ❌

For more details on these failures, seethis check.

Results for commit13aac76.

♻️ This comment has been updated with latest results.

@lucasssvazlucasssvaz added the hil_testRun Hardware Tests labelJun 19, 2025
@JakubAndrysek
Copy link
CollaboratorAuthor

@lucasssvaz
Copy link
Member

All tests passedhttps://github.com/JakubAndrysek/arduino-esp32/actions/runs/15757180922

These are the compilation tests and not the runtime tests. Either way HW tests are passing and I've checked the wokwi run on your fork. Everything looks good.

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelJun 23, 2025
@me-no-devme-no-dev merged commit95ae8cf intoespressif:masterJun 23, 2025
47 of 56 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

hil_testRun Hardware TestsStatus: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JakubAndrysek@lucasssvaz@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp