NotificationsYou must be signed in to change notification settings
Fork7.8k
Star15.9k

fix: Delete 8M flash option for xiao_esp32_s3_plus#11476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 1 commit intoespressif:masterfromis-qian:master

Jun 17, 2025

Merged

fix: Delete 8M flash option for xiao_esp32_s3_plus#11476

me-no-dev merged 1 commit intoespressif:masterfromis-qian:master

Jun 17, 2025

Conversation

Copy link

Contributor

is-qian commentedJun 17, 2025

Firstly, the xiao_esp32_s3_plus does not support 8M flash. When the 8M flash is selected by default, the PartitionScheme uses the 16M flash configuration by default, which causes program errors.

fix: Delete 8M flash option for xiao_esp32_s3_plus.

bc13d5c

is-qian requested a review fromP-R-O-C-H-Y as acode owner

June 17, 2025 03:07

Copy link

Contributor

github-actionsbot commentedJun 17, 2025•
edited
Loading

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"fix: Delete 8M flash option for xiao_esp32_s3_plus."`: summary should not end with a period (full stop) Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello is-qian, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstbc13d5c