NotificationsYou must be signed in to change notification settings
Fork7.7k
Star15.1k

fix(example): led flash not working if not using default model in camera example.#11466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 2 commits intoespressif:masterfromHighDoping:master

Jul 2, 2025

Merged

fix(example): led flash not working if not using default model in camera example.#11466

me-no-dev merged 2 commits intoespressif:masterfromHighDoping:master

Jul 2, 2025

+53 −50

Conversation

Copy link

Contributor

HighDoping commentedJun 14, 2025

Description of Change

LED flash do not work on some boards with esp32-cam example because the pin is always set to 22. This PR changes the pin definition to be set dynamically by setupLedFlash().

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with AI Thinker ESP32-CAM

HighDoping requested a review froma team as acode owner

June 14, 2025 01:44

Copy link

CLAassistant commentedJun 14, 2025•
edited
Loading

All committers have signed the CLA.

Copy link

Contributor

github-actionsbot commentedJun 14, 2025•
edited
Loading

	Messages
📖	🎉 Good Job! All checks are passing!

👋Hello HighDoping, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstf7004ef

HighDoping force-pushed themaster branch from04bac55 to02b2e28Compare

June 14, 2025 01:49

P-R-O-C-H-Y approved these changes

Jun 16, 2025

View reviewed changes

P-R-O-C-H-Y added Type: Example

Issue is related to specific example.

Status: Review neededIssue or PR is awaiting review labels

Jun 16, 2025

P-R-O-C-H-Y requested a review fromlucasssvaz

June 16, 2025 06:54

P-R-O-C-H-Y changed the title~~fix(esp32): led flash not working if not using default model in esp32-cam example.~~fix(example): led flash not working if not using default model in camera example.

Jun 16, 2025

Copy link

Contributor

github-actionsbot commentedJun 16, 2025•
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32S3	💚 -4	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	💚 -4	0	0.00	0.00	0	0	0.00	0.00
ESP32	💚 -4	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32S3		ESP32S2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/ESP32/examples/Camera/CameraWebServer	-	-	-	-	-	-
ESP32/examples/Camera/CameraWebServer (2)	💚 -4	0	💚 -4	0	💚 -4	0
ESP32/examples/Camera/CameraWebServer (3)	💚 -4	0	-	-	-	-

me-no-dev reviewed

Jun 16, 2025

View reviewed changes

libraries/ESP32/examples/Camera/CameraWebServer/app_httpd.cpp Outdated

		#define CONFIG_LED_MAX_INTENSITY 255

		int led_pin = 22; // Store the actual LED pin used

Copy link

Member

me-no-devJun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

22 is invalid GPIO on some chips. Code should be reworked so thatCONFIG_LED_ILLUMINATOR_ENABLED andLED_LEDC_GPIO are defined in the camera board config and not just be enabled by default

Copy link

ContributorAuthor

HighDopingJun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for review, I'm working on a version that use#if defined(LED_GPIO_NUM) to check if LED is available.
I'll test on real hardware this weekend and upload the new fix.

HighDoping requested a review fromme-no-dev

June 21, 2025 01:56

HighDoping force-pushed themaster branch from2905b3f todbce09dCompare

June 23, 2025 11:56

fix(example): led flash not working if not using default model in cam…

00edff3

…era examplefix(example): add camera_config.h and enable LED FLASH based on board modelfix(example): Remove face detection description as no longer supported

HighDoping force-pushed themaster branch fromdbce09d to00edff3Compare

June 23, 2025 11:59