NotificationsYou must be signed in to change notification settings
Fork7.7k
Star15.1k

feat(zigbee): Add method to set/get/report analog output#11431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 4 commits intomasterfromfeat/zigbee-analog-output-report

Jun 4, 2025

Merged

feat(zigbee): Add method to set/get/report analog output#11431

me-no-dev merged 4 commits intomasterfromfeat/zigbee-analog-output-report

Jun 4, 2025

Conversation

Copy link

Member

P-R-O-C-H-Y commentedJun 4, 2025

Description of Change

This pull request introduces updates to the Zigbee library, focusing on enhancing support for analog output functionality.
New methods added:

boolsetAnalogOutput(float analog);floatgetAnalogOutput();boolreportAnalogOutput();

Tests scenarios

Tested with ESP32-C6 and theZigbee_Analog_Input_Output example connecting to the HomeAssistant.

Related links

feat(zigbee): Add methot to set,get,report analog output

fa56f6f

P-R-O-C-H-Y self-assigned this

Jun 4, 2025

P-R-O-C-H-Y added the Status: Review neededIssue or PR is awaiting review label

Jun 4, 2025

P-R-O-C-H-Y added this toArduino ESP32 Core Project Roadmap

Jun 4, 2025

P-R-O-C-H-Y added the Area: ZigbeeIssues and Feature Request about Zigbee label

Jun 4, 2025

github-project-automationbot moved this toTodo inArduino ESP32 Core Project Roadmap

Jun 4, 2025

Copy link

Contributor

github-actionsbot commentedJun 4, 2025•
edited
Loading

	Messages
📖	🎉 Good Job! All checks are passing!

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against9068d88

fix(ci): Update json file for example

38cd70f

P-R-O-C-H-Y requested review fromCopilot,me-no-dev,lucasssvaz andSuGlider

June 4, 2025 11:13

CopilotAI reviewed

Jun 4, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances the Zigbee library to support analog output functionality by adding new APIs and updating related examples.

Introduces setAnalogOutput, getAnalogOutput, and reportAnalogOutput methods.
Updates the attribute change callback signature and keywords.
Adjusts example configurations and usage to target Zigbee coordinator/router devices.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
libraries/Zigbee/src/ep/ZigbeeAnalog.h	Added new analog output methods and modified callback signature.
libraries/Zigbee/src/ep/ZigbeeAnalog.cpp	Implemented new functions for setting and reporting analog output.
libraries/Zigbee/keywords.txt	Updated keywords in line with new API.
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/ci.json	Adjusted configuration for router mode.
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/Zigbee_Analog_Input_Output.ino	Updated mode check and added a call to setAnalogOutputResolution.